| Summary: | Review Request: langdetect - Language Detection Library for Java | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | gil cattaneo <puntogil> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, panemade, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | langdetect-1.1-0.2.20120112.fc20 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-12-14 02:54:47 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | 1005800 | ||
| Bug Blocks: | |||
|
Description
gil cattaneo
2013-09-09 12:14:40 UTC
Spec URL: http://gil.fedorapeople.org/langdetect.spec SRPM URL: http://gil.fedorapeople.org/langdetect-1.1-0.1.20120112.fc19.src.rpm Issues: 1. Please do not add a license file which is not upstream. It is enough to ask upstream to include it. 2. After the license is added, I'd make langdetect-javadoc co-own /usr/share/doc/langdetect/LICENSE-2.0.txt to avoid the extra directory with one file. 3. suggested %description langdetect is a language detection library implemented in plain Java. It uses Bayesian filters generated from language samples retrieved from Wikipedia to guess the language of text, achieving accuracy above 99%. + Source URL works, checksum matches. + Spec file is very nice. + License is OK. + No rpmlint output. + Package follows Java packaging guidelines Everything seems OK. Package is APPROVED. (In reply to Zbigniew Jędrzejewski-Szmek from comment #2) > Issues: > 1. Please do not add a license file which is not upstream. It is enough to > ask upstream to include it. > reported @ http://code.google.com/p/language-detection/issues/detail?id=57 usually we must add license txt file if this one is missing > 2. After the license is added, I'd make langdetect-javadoc co-own > /usr/share/doc/langdetect/LICENSE-2.0.txt to avoid the extra directory with > one file. > ? > 3. suggested %description > langdetect is a language detection library implemented in plain Java. > It uses Bayesian filters generated from language samples retrieved from > Wikipedia to guess the language of text, achieving accuracy above 99%. > Done > + Source URL works, checksum matches. > + Spec file is very nice. > + License is OK. > + No rpmlint output. > + Package follows Java packaging guidelines > > Everything seems OK. Thanks! New Package SCM Request ======================= Package Name: langdetect Short Description: Language Detection Library for Java Owners: gil Branches: f20 InitialCC: java-sig (In reply to gil cattaneo from comment #4) > (In reply to Zbigniew Jędrzejewski-Szmek from comment #2) > > Issues: > > 1. Please do not add a license file which is not upstream. It is enough to > > ask upstream to include it. > > > reported @ http://code.google.com/p/language-detection/issues/detail?id=57 > usually we must add license txt file if this one is missing The guidelines say: It is important to reiterate that in situations where the indicated license does not imply a requirement that the license be distributed along with the source/binaries, Fedora packagers are NOT required to manually include the full license text when it is absent from the source code. but are still encouraged to point out this issue to upstream and encourage them to remedy it. ... I took this to mean that the license file should *not* be included, but I guess it is allowed, just not required. So you're fine. > > 2. After the license is added, I'd make langdetect-javadoc co-own > > /usr/share/doc/langdetect/LICENSE-2.0.txt to avoid the extra directory with > > one file. The first part of the sentence was made in light of 1., so let me amend it to: 2. I'd make langdetect-javadoc co-own /usr/share/doc/langdetect/LICENSE-2.0.txt to avoid the extra directory with one file. Git done (by process-git-requests). langdetect-1.1-0.2.20120112.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/langdetect-1.1-0.2.20120112.fc20 langdetect-1.1-0.2.20120112.fc20 has been pushed to the Fedora 20 testing repository. langdetect-1.1-0.2.20120112.fc20 has been pushed to the Fedora 20 stable repository. |