| Summary: | stapling of an extension in p11-kit-trust (sometimes) doesn't work - Heisenbug? | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kai Engert (:kaie) (inactive account) <kengert> | ||||
| Component: | p11-kit | Assignee: | Stef Walter <stefw> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 19 | CC: | kengert, mclasen, stefw, tmraz | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | p11-kit-0.18.7-1.fc19 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | |||||||
| : | 1007812 (view as bug list) | Environment: | |||||
| Last Closed: | 2013-11-03 04:33:05 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1007812 | ||||||
| Attachments: |
|
||||||
|
Description
Kai Engert (:kaie) (inactive account)
2013-09-09 20:03:25 UTC
Sounds bad. Investigating. (In reply to Kai Engert (:kaie) from comment #0) > (I'm worried this unreliable stapling might also cause the distrust stapling > to not be effective.) For what it's worth, we don't use stapling to do distrust in Fedora 19 ca-certificates. So there's likely less cause for worry. Created attachment 797260 [details]
Test case for bug where stapled extensions don't apply
Seems to happen if loaded after certificate.
Can reproduce. This is a race condition. The attached patch makes the tests fail. The problem is where the certificate is loaded before the stapled certificate extension. We have code to account for loading both ways, however it seems to be broken. Test case failure, when above patch is applied.
.......F.......................
There was 1 failure:
1) test_build_certificate_staple_ca_backwards: test-builder.c:470: attribute does not match: expected { CKA_CERTIFICATE_CATEGORY = 2 (authority) } but found { CKA_CERTIFICATE_CATEGORY = 3 (other-entry) }
!!!FAILURES!!!
Runs: 31 Passes: 30 Fails: 1
FAIL: test-builder
Patch upstream. Scratch build with the upstream patch. http://koji.fedoraproject.org/koji/taskinfo?taskID=5930658 Kai, have you had a chance to test this patch? p11-kit-0.18.7-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/p11-kit-0.18.7-1.fc19 (In reply to Stef Walter from comment #7) > Kai, have you had a chance to test this patch? No, given how painful it was to test this issue, and how intermittent it was, I'd prefer if you could come up with a good testing strategy. Understood ... We have an upstream test case for this. So I've pushed this an an update to fix the issue. As you noted, it should be rare to run into this, given it's intermitancy and the fact that we now have a better Entrust Root CA cert. Package p11-kit-0.18.7-1.fc19: * should fix your issue, * was pushed to the Fedora 19 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing p11-kit-0.18.7-1.fc19' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-19259/p11-kit-0.18.7-1.fc19 then log in and leave karma (feedback). p11-kit-0.18.7-1.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. |