Bug 1006116
| Summary: | Review Request: WALinuxAgent - The Windows Azure Linux Agent | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michael Hampton <error> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | error, i, mattdm, rc040203 |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-06-30 13:17:20 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Michael Hampton
2013-09-10 04:17:20 UTC
1. URL is invalid. I don't know why you point the URL to a redirect page of https://github.com/windows-azure/walinuxagent ---> https://github.com/WindowsAzure/WALinuxAgent Please change to this. Add Microshit link doesn't mean this is valid. 2. Requires: python-pyasn1 openssh openssl util-linux sed grep sudo iptables You don't need to add "util-linux sed grep sudo" 3. BuildRequires: systemd python-setuptools missing python2-devel 4. %setup -q -n %{name}-%{name}-%{version} # github does this to tarballs github never does this unless some people like this kind of naming way. If you can change it, I recommend "%{name}-%{version}" so you can use %setup -q without %{name}-%{version} or even this weird one "%{name}-%{name}-%{version}" 5. Nothing to build? No python setup.py build? 6. python setup.py install --prefix=%{_prefix} --lnx-distro='redhat' --init-system='systemd' --root=%{buildroot} should be {__python2} setup.py install --prefix=%{_prefix} --lnx-distro='redhat' --init-system='systemd' --root=%{buildroot} 7. %{buildroot}/%{_localstatedir}/log you don't need to add slash between %{buildroot} and %{_localstatedir} just %{buildroot}%{_localstatedir}/log as rpm -E %{_localstatedir} eq /var so if you add a slash the URI will be: //var/log 8. %post preun postun section are all not perfect for f18+ Please check http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd 9. You should avoid using sth. like: %defattr(0644,root,root,0755) and %attr(0755,root,root) Make sure that these file perms are correct during installation, and correct the wrong ones after installation. Hi Christopher, Thanks for your comments. I have addressed them as follows: 1. This was leftover from upstream. I fixed the URL. 2. This was leftover from upstream. I removed these from the spec file. 3. I added this in to the spec file. 4. The upstream tarball really does have this directory structure. You can download it for yourself and look :) The packaging guidelines said I'm not supposed to alter the tarball (except for patents or binaries in the tarball or other really bad stuff). So that's why this is here in %setup. 5. Upstream doesn't have any build function in their setup.py script. But I added this in anyway, just in case they start doing something later. 6. I have made this change in the spec file. 7. I have made this change in the spec file. 8. I have made these changes in the spec file. 9. I have made these changes in the spec file and manually verified all the permissions in the resulting build. The resulting files can be found at: Spec URL: http://linux.ringingliberty.com/tmp/WALinuxAgent.spec SRPM URL: http://linux.ringingliberty.com/tmp/WALinuxAgent-1.4.0-4.fc19.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5916543 Thanks What's that (From your spec)? ... %pre # Nothing to do true ... Why is this present? Seems entirely superflous to me. (In reply to Ralf Corsepius from comment #3) > What's that (From your spec)? > ... > %pre > # Nothing to do > true > ... > > Why is this present? Seems entirely superflous to me. Yes, it's superfluous. It also came from upstream. I'd be happy to remove it if it's a problem. (In reply to Michael Hampton from comment #4) > Yes, it's superfluous. It also came from upstream. I'd be happy to remove it > if it's a problem. Yes, please remove it. It's a latent source of errors. (In reply to Ralf Corsepius from comment #5) > (In reply to Michael Hampton from comment #4) > > Yes, it's superfluous. It also came from upstream. I'd be happy to remove it > > if it's a problem. > Yes, please remove it. It's a latent source of errors. OK, this is now removed: Spec URL: http://linux.ringingliberty.com/tmp/WALinuxAgent.spec SRPM URL: http://linux.ringingliberty.com/tmp/WALinuxAgent-1.4.0-5.fc19.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5929997 Have you tried to find a sponsor? You need to find a sponsor initiatively: https://admin.fedoraproject.org/accounts/group/members/packager/*/sponsor *** This bug has been marked as a duplicate of bug 1159660 *** |