Bug 1006230

Summary: pretrans scriplet uses shell commands
Product: [Fedora] Fedora Reporter: Amit Saha <asaha>
Component: sagemathAssignee: Rex Dieter <rdieter>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 20CC: ebaak, kparal, paulo.cesar.pereira.de.andrade, rdieter
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: AcceptedFreezeException
Fixed In Version: sagemath-5.9-9.fc18 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-09-19 02:43:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 980650    

Description Amit Saha 2013-09-10 09:34:39 UTC
Description of problem:

sage.spec has this in it's spec file:

########################################################################
%pretrans
# Temporary due to moving directory to symlink
if [ ! -L %{SAGE_ROOT}/devel -a -d %{SAGE_ROOT}/devel ]; then
    mkdir %{SAGE_SRC}
    mv %{SAGE_ROOT}/devel/* %{SAGE_SRC}
    rmdir %{SAGE_ROOT}/devel
    ln -s src %{SAGE_ROOT}/devel
fi

As per discussions here [1], and [2] I believe, it shouldn't be doing this. This causes it to fail dependency check when included in the Fedora Scientific Spin [3]:
DEBUG util.py:264:  Error creating Live CD : Dependency check failed : (('sagemath', '5.10', '2.fc20'), ('/bin/sh', ''), 0, 0, None)

[1] https://lists.fedoraproject.org/pipermail/spins/2013-September/003432.html
[2] https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#The_.25pretrans_scriptlet
[3] http://kojipkgs.fedoraproject.org//work/tasks/4116/5914116/root.log



Version-Release number of selected component (if applicable):


How reproducible:

Always

Steps to Reproduce:
1.Add sagemath to a kickstart file and attempt to create a live image.
2.
3.

Actual results:

Dependency failure


Expected results:

installs correctly.

Additional info:

Comment 1 Rex Dieter 2013-09-10 11:31:55 UTC
I took care of it,

%changelog
* Tue Sep 10 2013 Rex Dieter <rdieter> 5.10-3
- pretrans scriplet uses shell commands (#1006230)

and backported to f19/f18 branches too

Comment 2 Paulo Andrade 2013-09-10 15:31:08 UTC
(In reply to Rex Dieter from comment #1)
> I took care of it,
> 
> %changelog
> * Tue Sep 10 2013 Rex Dieter <rdieter> 5.10-3
> - pretrans scriplet uses shell commands (#1006230)
> 
> and backported to f19/f18 branches too

Thanks!

Actually, that can be removed, as now it should be a noop.
It was added to allow clean upgrades for users that were
installing from the private repo I had at pcpa.fedorapeople.org,
as there were some directory layout changes when making sagemath
an "official" fedora package, and I am afraid having it in %pre
is unlikely to work due to the way rpm works.
Renaming symlink to/from directory is a known long standing
rpm problem.

Comment 3 Fedora Update System 2013-09-10 22:14:44 UTC
sagemath-5.10-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/sagemath-5.10-3.fc20

Comment 4 Rex Dieter 2013-09-11 01:37:43 UTC
nominating freeze exception, fixes compose for Scientific spin.

Comment 5 Fedora Update System 2013-09-11 16:58:44 UTC
Package sagemath-5.10-3.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing sagemath-5.10-3.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-16422/sagemath-5.10-3.fc20
then log in and leave karma (feedback).

Comment 6 Kamil Páral 2013-09-12 08:55:00 UTC
Discussed at 2013-09-11 blocker review meeting [1]. Breaks compose for a non-release-blocking spin (scientific) and a tested fix would be considered past freeze.

[1] http://meetbot.fedoraproject.org/fedora-blocker-review/2013-09-11/

Comment 7 Amit Saha 2013-09-12 17:15:45 UTC
I tested sagemath-5.10-3.fc20 by using it to build the Scientific spin and added my Karma accordingly.

Is there an easier way to test the fix so that I can encourage others to leave karma on it?

Comment 8 Fedora Update System 2013-09-15 01:14:57 UTC
sagemath-5.10-4.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/sagemath-5.10-4.fc20

Comment 9 Fedora Update System 2013-09-15 01:15:52 UTC
sagemath-5.9-8.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/sagemath-5.9-8.fc19

Comment 10 Fedora Update System 2013-09-15 01:16:55 UTC
sagemath-5.9-8.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/sagemath-5.9-8.fc18

Comment 11 Fedora Update System 2013-09-17 17:56:16 UTC
sagemath-5.9-9.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/sagemath-5.9-9.fc18

Comment 12 Fedora Update System 2013-09-17 17:57:42 UTC
sagemath-5.9-9.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/sagemath-5.9-9.fc19

Comment 13 Fedora Update System 2013-09-19 02:43:05 UTC
sagemath-5.10-4.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2013-09-27 00:39:18 UTC
sagemath-5.9-9.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2013-09-27 00:41:47 UTC
sagemath-5.9-9.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.