Bug 1006252

Summary: Qemu shouldn't be launched when the Identifiers of devices do not start with letters
Product: Red Hat Enterprise Linux 6 Reporter: Qian Guo <qiguo>
Component: qemu-kvmAssignee: Kevin Wolf <kwolf>
Status: CLOSED WONTFIX QA Contact: Virtualization Bugs <virt-bugs>
Severity: low Docs Contact:
Priority: low    
Version: 6.5CC: bsarathy, chayang, juzhang, michen, mkenneth, qzhang, rbalakri, sluo, virt-maint
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-01-27 15:41:22 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Qian Guo 2013-09-10 10:18:10 UTC
Description of problem:
If identifier of virtual device or driver does not start with a letter, qemu should refuse be started.
For rhel7, already has such limitation, so file this bug to limit it in rhel6

Version-Release number of selected component (if applicable):
# rpm -q qemu-kvm
qemu-kvm-0.12.1.2-2.400.el6.x86_64

How reproducible:
100%

Steps to Reproduce:
1.Try to boot a guest w/ devices that "id"s do not start with letters.
e.g.
/usr/libexec/qemu-kvm -cpu SandyBridge -enable-kvm -m 8G -smp 4,sockets=1,cores=4,threads=1 -name rhel6base  -drive file=rhel6u4uzcp1.qcow2,if=none,id=-drive-virtio-disk0,format=qcow2,werror=stop,rerror=stop,aio=native -device virtio-blk-pci,drive=-drive-virtio-disk0,id=_virtio-disk0 -boot menu=on -monitor stdio -netdev tap,id=0hostnet0,ifname=guest2,script=/etc/qemu-ifup -device e1000,netdev=0hostnet0,mac=54:52:1b:35:3c:17,id=1net -nodefaults -nodefconfig -vnc :20 -vga std  -device virtio-balloon-pci,id,id=1b -chardev socket,id=~a,path=/tmp/monitor,server,nowait -mon chardev=~a,mode=readline
2.
3.

Actual results:
Guest can boot up

Expected results:
Qemu should refuse to boot when the value of "id" is not started w/ a letter.

Additional info:

Comment 4 Kevin Wolf 2015-01-27 15:41:22 UTC
Restricting the allowed IDs after the fact in RHEL 6 has only little advantage
(basically just that you can't accidentally create a command line that won't
work any more in RHEL 7), but could possibly break existing users. Not worth
taking the risk at this point in the RHEL 6 lifecycle.