Bug 1006700

Summary: need add "interface" to virt-xml-validate manual page
Product: Red Hat Enterprise Linux 7 Reporter: EricLee <bili>
Component: libvirtAssignee: Jiri Denemark <jdenemar>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: low Docs Contact:
Priority: low    
Version: 7.0CC: ajia, dyuan, mzhan, pschiffe, rbalakri, sowang
Target Milestone: rcKeywords: ManPageChange, Patch, Upstream
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: libvirt-1.2.7-1.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1006699 Environment:
Last Closed: 2015-03-05 07:24:43 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 1006699    
Bug Blocks:    

Description EricLee 2013-09-11 07:02:44 UTC 
This bug still can be reproduced in RHEL7 in version libvirt-1.1.1-4.el7.

+++ This bug was initially created as a clone of Bug #1006699 +++

Description of problem:
need add "interface" to virt-xml-validate manual page

Version-Release number of selected component (if applicable):
# rpm -qa libvirt qemu-kvm ; uname -r
qemu-kvm-rhev-0.12.1.2-2.400.el6.x86_64
libvirt-0.10.2-24.el6.x86_64
2.6.32-396.el6.x86_64

How reproducible:
100%

Steps to Reproduce:
# man virt-xml-validate
....
       Valid schema names currently include

       "domain"
           The schema for the XML format used by guest domains configuration

       "network"
           The schema for the XML format used by virtual network configuration

       "storagepool"
           The schema for the XML format used by storage pool configuration

       "storagevol"
           The schema for the XML format used by storage volume descriptions

       "nodedev"
           The schema for the XML format used by node device descriptions

       "capability"
           The schema for the XML format used to declare driver capabilities
....

there is no "interface" in it, however we can use like this:
# cat eth1.xml
<interface type='ethernet' name='eth1'>
  <start mode='onboot'/>
  <mac address='00:15:17:62:ae:e8'/>
</interface>

# virt-xml-validate eth1.xml interface
eth1.xml validates

Actual results:
see description

Expected results:
should include interface

Additional info:
it is also reproduced both in rhel7 and upstream.
Comment 2 Alex Jia 2013-09-11 09:16:54 UTC 
Patch on upstream:
http://www.redhat.com/archives/libvir-list/2013-September/msg00546.html
Comment 3 Jiri Denemark 2013-09-13 13:12:00 UTC 
"interface" is not the only schema missing. Fixed upstream by the following commits (in v1.1.2-120-g4583ccb):

commit ab4304b7e0b90a18c5ec528028d0f1a6d1317c8c
Author: Eric Blake <eblake>
Date:   Mon Aug 19 16:32:31 2013 -0600

    virt-xml-validate: add missing schemas
    
    We were failing to autoprobe which schema to use for several
    top-level XML elements.
    
    * tools/virt-xml-validate.in (TYPE): Recognize <domainsnapshot>,
    <filter>, and <secret>.
    
    Signed-off-by: Eric Blake <eblake>

commit 4583ccbcf72d5cfb3f078d208c3efbf9aab0d799
Author: Alex Jia <ajia>
Date:   Wed Sep 11 11:47:14 2013 +0800

    tools: add missing 'interface' type and update man page
    
    Signed-off-by: Alex Jia <ajia>
Comment 7 Song Wang 2014-12-15 05:00:42 UTC 
[root@localhost libvirt]# rpm -q libvirt
libvirt-1.2.8-10.el7.x86_64

[root@localhost libvirt]# man virt-xml-validate

..... 
      "storagevol"
           The schema for the XML format used by storage volume descriptions

       "nodedev"
           The schema for the XML format used by node device descriptions

       "capability"
           The schema for the XML format used to declare driver capabilities

       "nwfilter"
           The schema for the XML format used by network traffic filters

       "secret"
           The schema for the XML format used by secrets descriptions

       "interface"
           The schema for the XML format used by physical host interfaces
.........

[root@localhost libvirt]# cat eth1.xml 
<interface type='ethernet' name='eth1'>
  <start mode='onboot'/>
  <mac address='00:15:17:62:ae:e8'/>
</interface>

[root@localhost libvirt]# virt-xml-validate eth1.xml interface
eth1.xml validates

bug is fixed.
Comment 9 errata-xmlrpc 2015-03-05 07:24:43 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-0323.html