Bug 1006701

Summary: Can not stop nodejs-0.6 application successfully
Product: OpenShift Online Reporter: Wei Sun <wsun>
Component: ContainersAssignee: Fotios Lindiakos <fotios>
Status: CLOSED CURRENTRELEASE QA Contact: libra bugs <libra-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 2.xCC: jkeck, yadu
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-09-19 16:50:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Wei Sun 2013-09-11 07:02:45 UTC 
Description of problem:
Create a nodejs-0.6 app,and stop it,check the app's status via CLI,it shows stopped,but the app's url can be accessed.
If add something in local git repo and git push,the output shows  " /var/lib/openshift/523006c66cec0e9b22000c3d/nodejs/bin/control: line 147: [: : unary operator expected"

Version-Release number of selected component (if applicable):
INT(devenv_3769)
devenv_3772

How reproducible:
Always

Steps to Reproduce:
1.Create a nodejs-0.6 app
2.Change something and git push
3.Check the output
4.Stop the app
5.Check the app's status via CLI
6.Access the app's url

Actual results:
3.Counting objects: 5, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 287 bytes | 0 bytes/s, done.
Total 3 (delta 2), reused 0 (delta 0)
remote: Stopping NodeJS cartridge
remote: /var/lib/openshift/52300d357522309aee000007/nodejs/bin/control: line 147: [: : unary operator expected
remote: usage: kill [ -s signal | -p ] [ -a ] pid ...
remote:        kill -l [ signal ]
remote: Saving away previously installed Node modules
remote: Building NodeJS cartridge
remote: npm info it worked if it ends with ok
remote: npm info using npm.37
remote: npm info using node.20
remote: npm info preinstall OpenShift-Sample-App.0
remote: npm info build /var/lib/openshift/52300d357522309aee000007/app-root/runtime/repo
remote: npm info linkStuff OpenShift-Sample-App.0
remote: npm info install OpenShift-Sample-App.0
remote: npm info postinstall OpenShift-Sample-App.0
remote: npm info ok 
remote: Starting application nd
remote: Starting NodeJS cartridge
To ssh://52300d357522309aee000007.rhcloud.com/~/git/nd.git/
   c44f482..b12b269  master -> master

5.[wsun@dhcp-8-229 nd]$ rhc app-show nd --state
Cartridge nodejs-0.6 is stopped

6.App's url could be accessed.

Expected results:
App's url should not be accessed after stopping.

Additional info:
It works for nodejs-0.10
Comment 1 Fotios Lindiakos 2013-09-11 18:52:36 UTC 
Related to: Bug1006355, Bug1006908

Fixed in https://github.com/openshift/origin-server/pull/3619
Comment 2 Yan Du 2013-09-12 05:39:26 UTC 
test on devenv_3776,

1. no error show during push

[root@Daphne n6]# git add .; git commit -amp; git push[master 3a3b239] p
 Committer: root <root@Daphne.(none)>
 1 files changed, 1 insertions(+), 1 deletions(-)
Counting objects: 5, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 281 bytes, done.
Total 3 (delta 2), reused 0 (delta 0)
remote: Stopping NodeJS cartridge
remote: Saving away previously installed Node modules
remote: Building NodeJS cartridge
remote: npm info it worked if it ends with ok
remote: npm info using npm.37
remote: npm info using node.20
remote: npm info preinstall OpenShift-Sample-App.0
remote: npm info build /var/lib/openshift/5231504f6849bb75310000c3/app-root/runtime/repo
remote: npm info linkStuff OpenShift-Sample-App.0
remote: npm info install OpenShift-Sample-App.0
remote: npm info postinstall OpenShift-Sample-App.0
remote: npm info ok 
remote: Starting application n6
remote: Starting NodeJS cartridge
To ssh://5231504f6849bb75310000c3.rhcloud.com/~/git/n6.git/
   66e8f0b..3a3b239  master -> master


2. can be access in webpage(show 503 error) after stop the app.

move the bug to verified.