Bug 1006864

Summary: virsh domjobinfo command returns 1 on success if there is no job
Product: Red Hat Enterprise Linux 7 Reporter: Pavel Hrdina <phrdina>
Component: libvirtAssignee: Jiri Denemark <jdenemar>
Status: CLOSED CURRENTRELEASE QA Contact: Virtualization Bugs <virt-bugs>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 7.0CC: acathrow, dyuan, hliu, mzhan, zhwang, zsong
Target Milestone: rcKeywords: Upstream
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libvirt-1.1.1-5.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-06-13 13:23:01 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Pavel Hrdina 2013-09-11 12:13:39 UTC 
Description of problem:
The virsh command domjobinfo returns 1 on success if there is no job.

Version-Release number of selected component (if applicable):
upstream, libvirt-1.1.1-4.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. virsh start domain
2. virsh domjobinfo domain

Actual results:
Job type:         None

echo $? -> 1

Expected results:
Job type:         None

echo $? -> 0
Comment 1 Jiri Denemark 2013-09-12 09:34:56 UTC 
Fixed upstream by v1.1.2-107-gf084caa:

commit f084caae7c5db8ae03e7fafce164c73f65681843
Author: Jiri Denemark <jdenemar>
Date:   Wed Sep 11 15:49:48 2013 +0200

    virsh domjobinfo: Do not return 1 if job is NONE
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1006864
    
    Commit 38ab1225 changed the default value of ret from true to false but
    forgot to set ret = true when job is NONE. Thus, virsh domjobinfo
    returned 1 when there was no job running for a domain but it used to
    (and should) return 0 in this case.
Comment 3 Hao Liu 2013-09-16 03:36:13 UTC 
This patch is VERIFIED.

Package used:
libvirt-1.1.1-5.el7.x86_64

Verifying steps:

# virsh domjobinfo <domain>
Job type:         None        
# echo $?
0

In comparison with returning value 1 in
libvirt-1.1.1-4.el7.x86_64

So consider this VERIFIED.
Comment 4 Ludek Smid 2014-06-13 13:23:01 UTC 
This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.