Bug 1007216

Summary: Patch generator logic is present in EAP
Product: [JBoss] JBoss Enterprise Application Platform 6 Reporter: Jan Martiska <jmartisk>
Component: PatchingAssignee: Emanuel Muckenhuber <emuckenh>
Status: CLOSED CURRENTRELEASE QA Contact: Jan Martiska <jmartisk>
Severity: urgent Docs Contact: Russell Dickenson <rdickens>
Priority: unspecified    
Version: 6.2.0CC: brian.stansberry, dandread, jason.greene, jawilson, jdoyle, kconner, msimka, myarboro, olubyans
Target Milestone: ER6   
Target Release: EAP 6.2.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-12-15 16:22:38 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Jan Martiska 2013-09-12 06:39:05 UTC
Customers with EAP shouldn't be allowed to generate their own patches. The generator logic should be moved from EAP sources to a separate repository.

Comment 1 John Doyle 2013-09-12 13:03:01 UTC
Where is this, I have ER1 and don't know where it is.

Comment 2 Emanuel Muckenhuber 2013-09-12 13:07:49 UTC
It's part of the codebase and therefore in the .jar. We do have restrictions on the modules export, so nothing should be able to consume this by chance. 

However i am going to remove the code once we found a permanent location for the patch generation tool.

Comment 3 Jan Martiska 2013-09-12 13:12:08 UTC
The logic is in classes inside org/jboss/as/patching/main/wildfly-patching-7.3.0.Final-redhat-1.jar. The script for running the generator (patch-gen.sh) does not work in ER1, because of another issue - the module org.jboss.as.patching.generator is missing in ER1 (productization issue), but that issue is superseded by the fact that the generator logic should be removed completely.

Comment 8 Jan Martiska 2013-10-17 12:44:55 UTC
Two files were probably forgotten and left in the codebase.
patching/src/main/java/org/jboss/as/patching/generator/Usage.java && UsageMessages.java

This actually does no harm, but Emanuel said he would delete them soon.
Setting this to VERIFIED as of 6.2.0.ER6.