Bug 1007515

Description of problem:

I tried creating a backup while my openstack-cinder-backup service was down. 
although we raise an error that we cannot find the service, we change the volume status to backing up and continue to trying and create a new backup. 

changing the volume status is problematic since there are specific things that the user cannot do if the volume status is not available. 

Version-Release number of selected component (if applicable):


How reproducible:

100%

Steps to Reproduce:
1. stop openstack-cinder-backup 
2. create a volume 
3. create a backup for the volume 

Actual results:

although we report the error we change the volume status to backing up and try to create a new backup 

Expected results:

we should exit if we can't find service 

Additional info:


[root@nott-vdsa ~(keystone_admin)]# cinder list 
+--------------------------------------+-----------+--------------+------+-------------+----------+-------------+
|                  ID                  |   Status  | Display Name | Size | Volume Type | Bootable | Attached to |
+--------------------------------------+-----------+--------------+------+-------------+----------+-------------+
| 797eea39-a91b-4a21-ab59-7c0458aa0076 | available |    dafna     |  1   |     None    |  False   |             |
+--------------------------------------+-----------+--------------+------+-------------+----------+-------------+
[root@nott-vdsa ~(keystone_admin)]# less /var/log/cinder/volume.log 
[root@nott-vdsa ~(keystone_admin)]# cinder backup-create 797eea39-a91b-4a21-ab59-7c0458aa0076
ERROR: Service cinder-backup could not be found.
[root@nott-vdsa ~(keystone_admin)]# less /var/log/cinder/volume.log 
[root@nott-vdsa ~(keystone_admin)]# cinder list 
+--------------------------------------+------------+--------------+------+-------------+----------+-------------+
|                  ID                  |   Status   | Display Name | Size | Volume Type | Bootable | Attached to |
+--------------------------------------+------------+--------------+------+-------------+----------+-------------+
| 797eea39-a91b-4a21-ab59-7c0458aa0076 | backing-up |    dafna     |  1   |     None    |  False   |             |
+--------------------------------------+------------+--------------+------+-------------+----------+-------------+
[root@nott-vdsa ~(keystone_admin)]# cinder backup-list 
+--------------------------------------+--------------------------------------+----------+------+------+--------------+-----------+
|                  ID                  |              Volume ID               |  Status  | Name | Size | Object Count | Container |
+--------------------------------------+--------------------------------------+----------+------+------+--------------+-----------+
| 980157f6-97a0-499a-ba9d-4934978d3c81 | 797eea39-a91b-4a21-ab59-7c0458aa0076 | creating | None |  1   |     None     |    None   |
+--------------------------------------+--------------------------------------+----------+------+------+--------------+-----------+
[root@nott-vdsa ~(keystone_admin)]# /etc/init.d/openstack-cinder-backup status
openstack-cinder-backup is stopped