Bug 1007599

Summary: Fix FTBFS when winpthreads is available
Product: [Fedora] Fedora Reporter: Erik van Pienbroek <erik-fedora>
Component: mingw-wine-geckoAssignee: Andreas Bierfert <andreas.bierfert>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: andreas.bierfert, erik-fedora, mike
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-09-16 16:19:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Proposed patch
none
Proposed patch (try2) none

Description Erik van Pienbroek 2013-09-12 21:47:26 UTC 
Created attachment 797036 [details]
Proposed patch

Hi Andreas,

As you may have heard we're planning on introducing winpthreads in the Fedora mingw stack. Tests have shown that wine-gecko currently fails to build when winpthreads is available. This was mentioned multiple times in the last couple of months on the Fedora mingw mailing list and the upstream mingw-w64 mailing list. Wine-gecko developer Jacek Caban noticed this and provided us a patch. This patch indeed does resolve the build issue and therefore a bug report was filed upstream along with the patch: https://bugzilla.mozilla.org/show_bug.cgi?id=893444

The patch is approved and applied upstream already, but no new wine-gecko releases were done recently. As we're about to introduce winpthreads in Fedora (20/rawhide) in a couple of days I would like to manually apply this patch in the mingw-wine-gecko package for now.

Are you okay with me applying the attached changes? (I'm provenpackager so I can push the commit myself)
Comment 1 Erik van Pienbroek 2013-09-12 21:48:52 UTC 
Created attachment 797037 [details]
Proposed patch (try2)
Comment 2 Andreas Bierfert 2013-09-15 09:06:30 UTC 
Sure go ahead :)
Comment 3 Erik van Pienbroek 2013-09-15 19:50:48 UTC 
The commit has just been pushed to rawhide and a build is on its way :)
Comment 4 Erik van Pienbroek 2013-09-16 16:19:59 UTC 
Build completed successfully