Bug 1007711

Summary: Number of gears count in the upgrade summary will be doubled if there were inactive gears in the gear queue when migrate nodes
Product: OpenShift Online Reporter: Meng Bo <bmeng>
Component: ContainersAssignee: Dan Mace <dmace>
Status: CLOSED CURRENTRELEASE QA Contact: libra bugs <libra-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 2.x   
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-09-19 16:51:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Meng Bo 2013-09-13 07:54:44 UTC
Description of problem:
Check the oo-admin-upgrade summary when the migration is done. The value of "# of gears" will be doubled if there were inactive gears in the queue.

Version-Release number of selected component (if applicable):
devenv-stage_471

How reproducible:
always

Steps to Reproduce:
1. Prepare test data 
2. Do node upgrade
oo-admin-upgrade upgrade-node --version 2.0.33 --ignore-cartridge-version
3. Stop some gears in your list
4. Do node upgrade
oo-admin-upgrade upgrade-node --version 2.0.33 --ignore-cartridge-version

Actual results:
The "# of gears" count in step 4 will be doubled to the real gears count.

Expected results:
The value of "# of gears" should show the actual gear number.

Additional info:
Step2:
# oo-admin-upgrade upgrade-node --version 2.0.33 --ignore-cartridge-version
Upgrader started with options: {:version=>"2.0.33", :ignore_cartridge_version=>true, :target_server_identity=>nil, :upgrade_position=>1, :num_upgraders=>1, :max_threads=>12, :gear_whitelist=>[]}
Building new upgrade queues and cluster metadata
Getting all active gears...
Getting all logins...
Writing 19 entries to gear queue for node ip-10-184-31-97 at /tmp/oo-upgrade/gear_queue_ip-10-184-31-97
Writing node queue to /tmp/oo-upgrade/node_queue
Writing cluster metadata to /tmp/oo-upgrade/cluster_metadata
Loading cluster metadata from /tmp/oo-upgrade/cluster_metadata
Loading node queue from /tmp/oo-upgrade/node_queue
Upgrading node ip-10-184-31-97 from gear queue file at /tmp/oo-upgrade/gear_queue_ip-10-184-31-97
1 of 1 nodes completed
Writing updated node queue to /tmp/oo-upgrade/node_queue
#####################################################
Summary:
# of users: 4
# of gears: 19
# of failures: 0
# of leftovers: 0
Gear counts per thread: [nil, nil, nil, 19]

Timings:
    start=1379056099.263s
    total=131.868s
Additional timings:
    gather_active_gears_total_time=20.724s
    gather_users_total_time=0.022s
#####################################################


step4:
# oo-admin-upgrade upgrade-node --version 2.0.33 --ignore-cartridge-version
Upgrader started with options: {:version=>"2.0.33", :ignore_cartridge_version=>true, :target_server_identity=>nil, :upgrade_position=>1, :num_upgraders=>1, :max_threads=>12, :gear_whitelist=>[]}
Building new upgrade queues and cluster metadata
Getting all active gears...
Getting all logins...
Writing 18 entries to gear queue for node ip-10-184-31-97 at /tmp/oo-upgrade/gear_queue_ip-10-184-31-97
Writing 1 entries to gear queue for node ip-10-184-31-97 at /tmp/oo-upgrade/gear_queue_ip-10-184-31-97
Writing node queue to /tmp/oo-upgrade/node_queue
Writing cluster metadata to /tmp/oo-upgrade/cluster_metadata
Loading cluster metadata from /tmp/oo-upgrade/cluster_metadata
Loading node queue from /tmp/oo-upgrade/node_queue
Upgrading node ip-10-184-31-97 from gear queue file at /tmp/oo-upgrade/gear_queue_ip-10-184-31-97
Upgrading node ip-10-184-31-97 from gear queue file at /tmp/oo-upgrade/gear_queue_ip-10-184-31-97
1 of 1 nodes completed
Writing updated node queue to /tmp/oo-upgrade/node_queue
#####################################################
Summary:
# of users: 4
# of gears: 38
# of failures: 0
# of leftovers: 0
Gear counts per thread: [nil, nil, 19]

Timings:
    start=1379056415.99s
    total=146.917s
Additional timings:
    gather_active_gears_total_time=20.768s
    gather_users_total_time=0.022s
#####################################################

Comment 2 openshift-github-bot 2013-09-13 17:52:15 UTC
Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/0f771ab0a159de7c9956035911f3a3fec0ed8387
Bug 1007711: Fix upgraded gear count reporting

Comment 3 Meng Bo 2013-09-16 06:01:11 UTC
Issue fixed on devenv-stage_472,

With 21 active apps and 5 stopped apps,

# oo-admin-upgrade upgrade-node --version 2.0.33 --ignore-cartridge-version
Upgrader started with options: {:version=>"2.0.33", :ignore_cartridge_version=>true, :target_server_identity=>nil, :upgrade_position=>1, :num_upgraders=>1, :max_threads=>12, :gear_whitelist=>[]}
Building new upgrade queues and cluster metadata
Getting all active gears...
Getting all logins...
Writing 21 entries to gear queue for node ip-10-117-43-163 at /tmp/oo-upgrade/gear_queue_ip-10-117-43-163
Writing 5 entries to gear queue for node ip-10-117-43-163 at /tmp/oo-upgrade/gear_queue_ip-10-117-43-163
Writing node queue to /tmp/oo-upgrade/node_queue
Writing cluster metadata to /tmp/oo-upgrade/cluster_metadata
Loading cluster metadata from /tmp/oo-upgrade/cluster_metadata
Loading node queue from /tmp/oo-upgrade/node_queue
Upgrading node ip-10-117-43-163 from gear queue file at /tmp/oo-upgrade/gear_queue_ip-10-117-43-163
Upgrading node ip-10-117-43-163 from gear queue file at /tmp/oo-upgrade/gear_queue_ip-10-117-43-163
1 of 1 nodes completed
Writing updated node queue to /tmp/oo-upgrade/node_queue
#####################################################
Summary:
# of users: 5
# of gears: 26
# of failures: 0
# of leftovers: 0
Gear counts per thread: [nil, nil, nil, 26]

Timings:
    start=1379310321.294s
    total=150.543s
Additional timings:
    gather_active_gears_total_time=20.809s
    gather_users_total_time=0.018s
#####################################################