Bug 1007783

Summary: Html label doens't save edited text
Product: [Retired] JBoss BPMS Platform 6 Reporter: Michael <mbiarnes>
Component: Form ModelerAssignee: Neus Miras <nmirasch>
Status: CLOSED CURRENTRELEASE QA Contact: Jan Hrcek <jhrcek>
Severity: medium Docs Contact:
Priority: high    
Version: 6.0.0CC: pzapataf
Target Milestone: ER5   
Target Release: 6.0.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-08-06 20:10:38 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
save button in the middle
none
Video showing current behavior - not saving edits none

Description Michael 2013-09-13 10:01:47 UTC 
Description of problem:
When adding a HTML field to a form and editing this the "save" button appears in the middle of the raised window (see attachment).
If we save something in the HTML label we have to do it twice. The first time the change isn't changed.


Version-Release number of selected component (if applicable):
kie-wb.SNAPSHOT-6.0.0-as-7.war in JBoss EAP 6.1

How reproducible:


Steps to Reproduce:
1. Create a form and add a HTML label
2. Edit HTML label
3. Add a text and save

Actual results:
You will see thta nothing is saved. You have to repeat this operation.

Expected results:
The edited text in the HTML label should be saved
Comment 3 Michael 2013-09-13 13:32:59 UTC 
Created attachment 797338 [details]
save button in the middle
Comment 4 Pedro Zapata 2013-09-18 09:36:58 UTC 
Related to this, if the form is closed and reopened, you can't edit labels. The following error appears: 



11:35:36,762 ERROR [org.jbpm.formModeler.core.processing.impl.FormStatusDataImpl] (http-localhost/127.0.0.1:8080-7) Error: : java.lang.ClassCastException: org.jbpm.formModeler.api.model.wrappers.I18nSet cannot be cast to org.jbpm.formModeler.core.wrappers.HTMLi18n
        at org.jbpm.formModeler.core.processing.fieldHandlers.HTMLi18nFieldHandler.isEmpty(HTMLi18nFieldHandler.java:87) [jbpm-form-modeler-ui-6.0.0-SNAPSHOT.jar:]
        at org.jbpm.formModeler.core.processing.fieldHandlers.HTMLi18nFieldHandler$Proxy$_$$_WeldClientProxy.isEmpty(HTMLi18nFieldHandler$Proxy$_$$_WeldClientProxy.java) [jbpm-form-modeler-ui-6.0.0-SNAPSHOT.jar:]
        at org.jbpm.formModeler.core.processing.impl.FormStatusDataImpl.<init>(FormStatusDataImpl.java:65) [jbpm-form-modeler-ui-6.0.0-SNAPSHOT.jar:]
        at org.jbpm.formModeler.core.processing.impl.FormProcessorImpl.read(FormProcessorImpl.java:435) [jbpm-form-modeler-ui-6.0.0-SNAPSHOT.jar:]
        at org.jbpm.formModeler.core.processing.impl.FormProcessorImpl.read(FormProcessorImpl.java:425) [jbpm-form-modeler-ui-6.0.0-SNAPSHOT.jar:]
Comment 5 Neus Miras 2013-09-18 11:08:24 UTC 
Fixed with follow commits:

Commits:
Master
https://github.com/droolsjbpm/jbpm-form-modeler/commit/e912113b723bf2f75ea2ebdab06beae28286ce1c

6.0.x
https://github.com/droolsjbpm/jbpm-form-modeler/commit/8481b4735911b54cd81e004dbf976018a05858db
Comment 6 Jan Hrcek 2013-10-21 06:33:01 UTC 
I checked with BPMS 6.0.0 ER4 deployed on EAP 6.1.

The problem with the save button appearing in the middle seems to be gone, but the HTML label text is still not saved - the HTML label text remains unchanged when edited and saved.

Please watch the current behavior in the video attached.
Comment 7 Jan Hrcek 2013-10-21 06:33:38 UTC 
I forgot to add: there are no exceptions in the server console / server.log
Comment 8 Jan Hrcek 2013-10-21 06:34:57 UTC 
Created attachment 814414 [details]
Video showing current behavior - not saving edits
Comment 9 Neus Miras 2013-10-21 10:08:10 UTC 
It was needed to launch the change event to update the html content. The fix is modify the script to intercept the event 'dataReady' too, which is thrown by the source mode change and allow update the content with what the user is viewing. This is done in the follow commits:

Commits
Master
https://github.com/droolsjbpm/jbpm-form-modeler/commit/9eb383641ba49246c8ba5c37f3a8365e952d992b

6.0.x
https://github.com/droolsjbpm/jbpm-form-modeler/commit/cd0eb2f59fbc98b54d6492c106abb0aa4d508cc6
Comment 10 Jan Hrcek 2013-12-02 09:39:51 UTC 
Ok, in ER5 it saves the edits correctly. Verified with BPMS 6.0.0 ER5