Bug 1007894
| Summary: | Not much friendly maven error message appears when there is some problem with project (e.g. with dependencies) | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Retired] JBoss BRMS Platform 6 | Reporter: | Radovan Synek <rsynek> | ||||||||
| Component: | Business Central | Assignee: | Roger Martínez <romartin> | ||||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Radovan Synek <rsynek> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | medium | ||||||||||
| Version: | 6.0.0 | CC: | etirelli, mwinkler, paradhya, pzapataf, romartin, rrajasek, rsynek, vigoyal | ||||||||
| Target Milestone: | ER1 | Keywords: | UserExperience | ||||||||
| Target Release: | 6.0.1 | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: |
Summary: A simple error with a Project (for example, missing dependencies) can cause an unfriendly Maven error message being provided to the user, with no details of the actual error.
Cause:
1.- Depedency fields were not mandatory
2.- Adding a non existing depedency manually produced a ugly exception to the client.
Consequence: Poor feedback to the client.
Fix:
1.- Depedency fields are now mandatory
2.- Adding a non existing dependecy produces a friendly error in the user console, no exception is thrown to the client.
Result: Improved feedback to the user about the error.
|
Story Points: | --- | ||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2014-08-06 19:57:02 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | |||||||||||
| Bug Blocks: | 1006308 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Radovan Synek
2013-09-13 14:06:57 UTC
Radovan, I think it is missing the screenshot attachment? Internal Whiteboard: Beta Blocker → Blocker Not critical for Beta, but need to address for GA Created attachment 798655 [details]
screen shot
Sorry Edson, I forgot to attach it.
Fixed. Basically two changes are performed: 1.- Depedency fields (groupId artifactId, versionID) are now mandatory. 2.- Adding a non existing dependecy produces a friendly error in the user console, no exception is thrown to the client. Commits to master ----------------- - https://github.com/droolsjbpm/kie-wb-common/commit/386ac3f8354b0f406446d8288a103b9d1e71c8c9 - https://github.com/droolsjbpm/drools/commit/4749ccec30e6245b69cff3b1090235b52ef2b01c Commits to 6.0.x ----------------- - https://github.com/droolsjbpm/kie-wb-common/commit/978312dfd4f106a252abc6c492d03f3851ce8169 - https://github.com/droolsjbpm/drools/commit/65a561a009db9366f15db34d60bbe2c070d68ac7 Created attachment 812857 [details]
fix performed: example of friendly error in the user console
I am afraid that what I got by simply following the steps to reproduce from the description of this issue does not look like the user friendly error message in Problems panel, but more like the same error screen as originally reported. A new screen shot attached. Created attachment 832715 [details]
second screen shot
No error can be created for any possible unexpected condition. The only way to reduce this is make sure the UI validates most of the possible outcomes, but the latest resort will always print the underlying exception, since it's the only available piece of information. @Radovan: Agree, it's still happening :S @Pedro: Agree, the UI was improved and fields cannot be empty. But you can add a GAV into the project pointing to an artifact that does not exist. Then, the UI will pass validations (as the fields are not empty), but when the server side compiles the project then it throws an exception to the client. This exception cannot be more friendly as it's important to show to the user the root cause, but it should not appear as an error popup screen, it should appear in Problems section. Further work on this ticket, if any, is postponed to 6.0.1. Fixed in master branch only, as this issue does not have the bloquer+ flag. The fix is based on catching maven build exceptions and build an instance of BuildMessages on the fly with the exception details information. Then, the exception is not shown in a popup, it's displayed in problems widget. Commit in master -> https://github.com/droolsjbpm/guvnor/commit/8fd816e118ba64d0b9f268f34ae69f61895b5df0 Please notice that the doc text provided applies to 6.0.1, as this issue is not fixed for 6.0.0 and therefore it's known issue for 6.0.0, not bug fix. Removing Fix and Result from 6.0.0 release notes should be sufficient. Commit on 6.0.x: https://github.com/droolsjbpm/guvnor/commit/77eb1d5ec35350c0bc395479e1d7e3b84d72f2a3 Verified with BRMS-6.0.1.ER1 qe_test_coverage:UX problem. |