| Summary: | Review Request: perl-Class-Tiny - Minimalist class construction | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jitka Plesnikova <jplesnik> |
| Component: | Package Review | Assignee: | Petr Šabata <psabata> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | notting, paul, psabata |
| Target Milestone: | --- | Flags: | psabata:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Class-Tiny-0.009-1.fc20 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-09-27 00:49:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 1008407, 1008809 | ||
|
Description
Jitka Plesnikova
2013-09-16 12:51:16 UTC
Since you're not including the dependencies for old Perls, you should probably BR: perl >= 5.14 rather than 5.8.1 The package is fine except for the bit pointed out by Paul. I'd suggest wrapping the dependency (both BR and the filter) in a condition checking for the version of perl available. My local build has this: %if %(perl -e 'print $] < 5.014 ? 1 : 0;') BuildRequires: perl(Devel::GlobalDestruction) %else %global __requires_exclude ^perl\\(Devel::GlobalDestruction\\) %endif I have a similar condition for the Perl < 5.10 support but Class-Tiny seems to have issues there (https://github.com/dagolden/Class-Tiny/issues/8) and a test build of Pod-Spell 1.07 on 5.8.8 failed for me with an error that suggested it was a Class::Tiny problem, whilst 5.10 passed OK. So I'd be inclined not to even try to support Perl < 5.10 at the moment. Updated files are on the same place. Spec URL: http://jplesnik.fedorapeople.org/perl-Class-Tiny/perl-Class-Tiny.spec SRPM URL: http://jplesnik.fedorapeople.org/perl-Class-Tiny/perl-Class-Tiny-0.008-1.fc21.src.rpm Well, additional minimum perl depdency or Class::Tiny fixes could be added later if we hit the problems you're referring to. I don't think that's a review blocker. Approving. New Package SCM Request ======================= Package Name: perl-Class-Tiny Short Description: Minimalist class construction Owners: jplesnik ppisar psabata Branches: f20 InitialCC: perl-sig Git done (by process-git-requests). perl-Class-Tiny-0.008-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Class-Tiny-0.008-1.fc20 Class-Tiny 0.009 is out now by the way. Package perl-Class-Tiny-0.008-1.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing perl-Class-Tiny-0.008-1.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-16942/perl-Class-Tiny-0.008-1.fc20 then log in and leave karma (feedback). perl-Class-Tiny-0.009-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Class-Tiny-0.009-1.fc20 perl-Class-Tiny-0.009-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. |