Bug 1008552
| Summary: | Add support for multiple instances to initscripts | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | James Juran <james.juran> |
| Component: | python-carbon | Assignee: | Jonathan Steffan <jonathansteffan> |
| Status: | CLOSED EOL | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 22 | CC: | james.juran, jonathansteffan, piotr1212, throck |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-07-19 19:27:11 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Attachments: | |||
|
Description
James Juran
2013-09-16 15:03:48 UTC
Thanks for the bug report. I've been aware of the upstream init scripts able to run multiple instances and have not taken the time to port this into the init script shipped (wanted to address the CVE first.) I will work on an update that includes the needed changes to support this and will submit and update once graphite-web-0.9.12-2 goes stable. Created attachment 799025 [details]
add support for multiple carbon daemon instances
Thank you for looking at this. I've since added support for multiple instances of carbon-relay and carbon-cache as well, in the same style. I'm currently running these in production.
One issue I haven't yet solved is that the old processed don't die with the automatic service restart, because they are done with the new initscript but the PID files are in the old format. Created attachment 805568 [details]
support multiple instances
I found that log files from multiple instances were stomping on each other. To avoid this, the initscripts need to not pass --logdir, which will let each instance create its own subdir of LOG_DIR to have its own set of log files.
I still have not come up with a good way to transition from the currently-released package. We could:
1) In the %pre script, do "service <daemontype> stop". That would stop the old one, but then the new version wouldn't automatically start.
2) Put code in the initscripts' stop functions to also stop old-style instances. This would work but would leave the initscripts cluttered forever.
If you have another idea that's better on how to do this, please let me know.
Created attachment 806019 [details] add support for multiple carbon daemon instances Merge changes now committed for bug 1013813 to make this easier to apply. James, Would you be willing to rebase this to rawhide and we'll get it applied? I'm unlikely to have time to do this and retest in the near future. Also, I haven't solved the issue mentioned in comment 3, which I think needs to be solved before this change is broadly released. If someone would like to take this bug and run with it please go ahead; otherwise I'll update the patch when I can. This bug appears to have been reported against 'rawhide' during the Fedora 22 development cycle. Changing version to '22'. More information and reason for this action is here: https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora22 Fedora 22 changed to end-of-life (EOL) status on 2016-07-19. Fedora 22 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. |