Bug 1008654

Summary: oo-admin-chk doesn't report gears that have server_identity set to null
Product: OpenShift Online Reporter: Thomas Wiest <twiest>
Component: PodAssignee: Ravi Sankar <rpenta>
Status: CLOSED CURRENTRELEASE QA Contact: libra bugs <libra-bugs>
Severity: low Docs Contact:
Priority: unspecified    
Version: 2.xCC: dmcphers, jhou, rpenta
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-04-24 21:34:39 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Thomas Wiest 2013-09-16 18:58:16 UTC 
Description of problem:
According to rchopra, oo-admin-chk will not report on gears that have server_identity set to null in mongo.

I think it should. Of course, if there are pending operations, then it should just move along, because one of those pending ops might set server_identity. 

However, if pending_ops is clear, then we absolutely want to know about any gear that has server_identity set to null.


Version-Release number of selected component (if applicable):
openshift-origin-broker-util-1.14.6-1.el6oso.noarch


How reproducible:
unknown

Steps to Reproduce:
0. These are step that I _think_ will repro, haven't tried. This is going off of a conversation I had with rchopra.

1. In mongo, set server_identity to null on a gear
2. run oo-admin-chk and notice that that oo-admin-chk doesn't report that gear


Actual results:
Doesn't report gears that have server_identity set to null


Expected results:
Should report gears that have server_identity set to null, *IF* pending_ops is clear.
Comment 1 Abhishek Gupta 2013-09-24 21:36:03 UTC 
Cannot reproduce it anymore. I believe it was fixed with --> https://github.com/openshift/origin-server/pull/3683
Comment 2 Abhishek Gupta 2013-09-24 21:36:50 UTC 
Added comments (comment 1) to the wrong bug.
Comment 3 Ravi Sankar 2014-04-02 22:11:31 UTC 
Fixed in https://github.com/openshift/origin-server/pull/5152
Comment 4 openshift-github-bot 2014-04-03 14:13:40 UTC 
Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/0de68a62e5ebe35e8e5a23dfe1b9412a75900b74
Bug 1008654 - oo-admin-chk: Report app gears with out server_identity field set in mongo
Comment 5 Jianwei Hou 2014-04-04 03:34:30 UTC 
Verified on devenv-stage_787
Create a gear and update its server_identity to null, then:
[root@ip-10-178-150-218 ~]# oo-admin-chk -l 1
Started at: 2014-04-04 03:32:55 UTC

Total gears found in mongo: 2
Total gears found on the nodes: 2
Total nodes that responded: 1

Finished at: 2014-04-04 03:33:36 UTC
Total time: 41.014s
Gear 533e2535bda311e529000020 exists but node 'ip-10-178-150-218' does not match DB server_identity ''
FAILED
Please refer to the oo-admin-repair tool to resolve some of these inconsistencies.