| Summary: | Review Request: libkkc-data - Language model data for libkkc | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Daiki Ueno <dueno> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | i18n-bugs, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | libkkc-data-0.2.7-2.fc20 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-11-10 07:27:56 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Daiki Ueno
2013-09-17 06:49:40 UTC
This is split from the libkkc package to reduce the build time of the package. libkkc-data takes some time to build, libkkc doesn't need it at build time, and libkkc-data upstream is less frequently updated than libkkc. Review:
+ package build successfully in mock
- rpmlint on rpms gave
libkkc-data.x86_64: E: no-binary
libkkc-data.x86_64: W: only-non-binary-in-usr-lib
libkkc-data.x86_64: W: no-documentation
libkkc-data-debuginfo.x86_64: E: empty-debuginfo-package
3 packages and 0 specfiles checked; 2 errors, 2 warnings.
+ Source validated to upstream as (sha256sum)
srpm tarball : 9e678755a030043da68e37a4049aa296c296869ff1fb9e6c70026b2541595b99
upstream tarball : 9e678755a030043da68e37a4049aa296c296869ff1fb9e6c70026b2541595b99
+ license is valid and included in COPYING
Suggestions:
1) Add %doc COPYING
also good if you are upstream then add some contents to file README, ChangeLog and add them in %doc
2) you may want to disable -debuginfo package by adding at the top of spec
# This is just data package that installs data files only
%global debug_package %{nil}
I see this is still valid https://bugzilla.redhat.com/show_bug.cgi?id=906248#c8
so, not to worry for rpmlint warning only-non-binary-in-usr-lib
When you import this package you first need to update libkkc.spec by removing libkkc-data subpackage and then build this package.
APPROVED.
I just saw that current f21 libkkc is 0.3.1 and you submitted libkkc-data 0.2.7 version. You may need to add Epoch to this spec. Sure. Thanks for the review. New Package SCM Request ======================= Package Name: libkkc-data Short Description: Language model data for libkkc Owners: ueno Branches: f20 f19 f18 InitialCC: i18n-team Git done (by process-git-requests). libkkc-data-0.2.7-2.fc20,libkkc-0.3.1-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/libkkc-data-0.2.7-2.fc20,libkkc-0.3.1-2.fc20 libkkc-data-0.2.7-2.fc20, libkkc-0.3.1-2.fc20 has been pushed to the Fedora 20 testing repository. libkkc-data-0.2.7-2.fc20, libkkc-0.3.1-2.fc20 has been pushed to the Fedora 20 stable repository. |