Bug 1009153
Summary: | Review Request: javolution - Real-time Java library | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Pete MacKinnon <pmackinn> | ||||||
Component: | Package Review | Assignee: | gil cattaneo <puntogil> | ||||||
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
Severity: | unspecified | Docs Contact: | |||||||
Priority: | unspecified | ||||||||
Version: | rawhide | CC: | notting, puntogil | ||||||
Target Milestone: | --- | Flags: | puntogil:
fedora-review+
kevin: fedora-cvs+ |
||||||
Target Release: | --- | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2013-11-14 21:39:01 UTC | Type: | Bug | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Attachments: |
|
Description
Pete MacKinnon
2013-09-17 19:45:55 UTC
hi there is a newer release in https://svn.java.net/svn/javolution~svn/tags/ regards Please read the comments in the Description. please, remove from spec file these BuildRequires: javapackages-tools BuildRequires: maven BuildRequires: maven-compiler-plugin BuildRequires: maven-install-plugin BuildRequires: maven-javadoc-plugin BuildRequires: maven-source-plugin BuildRequires: maven-surefire-plugin all Group fiels - no more required all Requires - added by java package tools (XMvn) fix unowned directory add %dir %{_javadir}/%{name} in main package if possible use pom macros e.g. %pom_remove_plugin javolution:colapi %pom_xpath_remove "pom:project/pom:build/pom:extensions[pom:groupId = 'org.jvnet.wagon-svn' ]" or %pom_xpath_remove "pom:project/pom:build/pom:extensions" fix license field License: BSD and Public domain these are under Public domain license Public domain ------------- /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/src/main/java/org/xml/sax/AttributeList.java /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/src/main/java/org/xml/sax/DTDHandler.java /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/src/main/java/org/xml/sax/DocumentHandler.java /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/src/main/java/org/xml/sax/EntityResolver.java /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/src/main/java/org/xml/sax/ErrorHandler.java /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/src/main/java/org/xml/sax/HandlerBase.java /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/src/main/java/org/xml/sax/InputSource.java /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/src/main/java/org/xml/sax/Locator.java /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/src/main/java/org/xml/sax/Parser.java /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/src/main/java/org/xml/sax/SAXException.java /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/src/main/java/org/xml/sax/SAXParseException.java remove bundled library already available in xml-commons-apis package or in OpenJDK rt.jar /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/src/main/java/org/xml/sax/Attributes.java /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/src/main/java/org/xml/sax/ContentHandler.java /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/src/main/java/org/xml/sax/SAXNotRecognizedException.java /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/src/main/java/org/xml/sax/SAXNotSupportedException.java /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/src/main/java/org/xml/sax/XMLFilter.java /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/src/main/java/org/xml/sax/XMLReader.java fix wrong-file-end-of-line-encoding /usr/share/doc/javolution/LICENSE.txt e.g. sed -i 's/\r//' LICENSE.txt not approved Created attachment 799593 [details]
review notes
(In reply to gil cattaneo from comment #3) > please, remove from spec file these > > BuildRequires: javapackages-tools > BuildRequires: maven > BuildRequires: maven-compiler-plugin > BuildRequires: maven-install-plugin > BuildRequires: maven-javadoc-plugin > BuildRequires: maven-source-plugin > BuildRequires: maven-surefire-plugin > > all Group fiels - no more required > all Requires - added by java package tools (XMvn) > > fix unowned directory > add %dir %{_javadir}/%{name} > in main package > > if possible use pom macros > e.g. > %pom_remove_plugin javolution:colapi > %pom_xpath_remove "pom:project/pom:build/pom:extensions[pom:groupId = > 'org.jvnet.wagon-svn' ]" > or > %pom_xpath_remove "pom:project/pom:build/pom:extensions" > > fix license field > License: BSD and Public domain should be correct as this last one License: BSD > > these are under Public domain license > because you must remove all bundled libraries https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries > already available in xml-commons-apis package or in OpenJDK rt.jar > /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/ > src/main/java/org/xml/sax/AttributeList.java > /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/ > src/main/java/org/xml/sax/DTDHandler.java > /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/ > src/main/java/org/xml/sax/DocumentHandler.java > /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/ > src/main/java/org/xml/sax/EntityResolver.java > /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/ > src/main/java/org/xml/sax/ErrorHandler.java > /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/ > src/main/java/org/xml/sax/HandlerBase.java > /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/ > src/main/java/org/xml/sax/InputSource.java > /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/ > src/main/java/org/xml/sax/Locator.java > /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/ > src/main/java/org/xml/sax/Parser.java > /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/ > src/main/java/org/xml/sax/SAXException.java > /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/javolution-5.5.1/ > src/main/java/org/xml/sax/SAXParseException.java > Feedback applied and some additional BR removed. However, adding %dir %{_javadir}/%{name} is not required as far as I can tell. This is a single jar package and thus there is no %{_javadir}/%{name}. New spec and latest SRPM (0.2) at same location. yes, i see sorry, but you should add also the new source rpm regards please. you should remove Group field in the main package and superfluous BuildArch: noarch in javadoc sub package regards Spec URL: http://pmackinn.fedorapeople.org/javolution/javolution.spec SRPM URL: http://pmackinn.fedorapeople.org/javolution/javolution-5.5.1-0.2.fc19.src.rpm Spec URL: http://pmackinn.fedorapeople.org/javolution/javolution.spec SRPM URL: http://pmackinn.fedorapeople.org/javolution/javolution-5.5.1-0.3.fc19.src.rpm Comment #8 re javadoc arc applied but most other Java packages have Group: Development/Libraries so no change there. Why do you think that's necessary? (In reply to Pete MacKinnon from comment #10) > Spec URL: http://pmackinn.fedorapeople.org/javolution/javolution.spec > SRPM URL: > http://pmackinn.fedorapeople.org/javolution/javolution-5.5.1-0.3.fc19.src.rpm > > Comment #8 re javadoc arc applied but most other Java packages have > > Group: Development/Libraries > > so no change there. Why do you think that's necessary? see https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Group_tag if you want use the package also in EPEL is requires, otherwise not necessary > Comment #8 re javadoc arc applied but most other Java packages have
usually if the main package is noarch also the sub package/s is/are noarch
Created attachment 800144 [details]
new review notes
approved New Package SCM Request ======================= Package Name: javolution Short Description: A Java library for real-time applications Owners: pmackinn Branches: f19 f20 f21 InitialCC: java-sig Git done (by process-git-requests). There's no such thing as a f21 branch yet... javolution-5.5.1-0.4.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/javolution-5.5.1-0.4.fc20 javolution-5.5.1-0.4.fc20 has been pushed to the Fedora 20 stable repository. |