Bug 1009350
| Summary: | generated output looks not correct | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Akira TAGOH <tagoh> | ||||||
| Component: | xorg-x11-fonts | Assignee: | Hans de Goede <hdegoede> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 19 | CC: | fonts-bugs, hdegoede, i18n-bugs, negativo17, pnemade, psatpute, xgl-maint | ||||||
| Target Milestone: | --- | Keywords: | i18n | ||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | xorg-x11-fonts-7.5-11.fc21 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2014-11-01 16:37:53 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1007493 | ||||||||
| Attachments: |
|
||||||||
|
Description
Akira TAGOH
2013-09-18 09:18:24 UTC
when I try to reproduce this I got fonts.scale with its contents as 5 sazanami-gothic.ttf -misc-Sazanami Gothic-medium-r-normal--0-0-0-0-c-0-ascii-0 sazanami-gothic.ttf -misc-Sazanami Gothic-medium-r-normal--0-0-0-0-c-0-iso10646-1 sazanami-gothic.ttf -misc-Sazanami Gothic-medium-r-normal--0-0-0-0-c-0-iso8859-1 sazanami-gothic.ttf -misc-Sazanami Gothic-medium-r-normal--0-0-0-0-c-0-iso8859-15 sazanami-gothic.ttf -misc-Sazanami Gothic-medium-r-normal--0-0-0-0-c-0-iso8859-9 whereas stock fonts.scale on system is 7 sazanami-gothic.ttf -misc-Sazanami Gothic-medium-r-normal--0-0-0-0-c-0-ascii-0 sazanami-gothic.ttf -misc-Sazanami Gothic-medium-r-normal--0-0-0-0-c-0-iso10646-1 sazanami-gothic.ttf -misc-Sazanami Gothic-medium-r-normal--0-0-0-0-c-0-iso8859-1 sazanami-gothic.ttf -misc-Sazanami Gothic-medium-r-normal--0-0-0-0-c-0-iso8859-15 sazanami-gothic.ttf -misc-Sazanami Gothic-medium-r-normal--0-0-0-0-c-0-iso8859-9 sazanami-gothic.ttf -misc-Sazanami Gothic-medium-r-normal--0-0-0-0-c-0-jisx0208.1983-0 sazanami-gothic.ttf -misc-Sazanami Gothic-medium-r-normal--0-0-0-0-c-0-jisx0208.1990-0 so exactly what is missing or required? this bug description says no entry for jisx0201.1976-0 in fonts.scale whereas other bug https://bugzilla.redhat.com/show_bug.cgi?id=1007493#c4 Did you try that with xorg-x11-fonts-misc installed? Anyway, I see the same result to the system's here and of course presuming that is missing jisx0201.1976-0 as I mentioned the above. Thanks. I have installed now xorg-x11-fonts-misc package. Now, I got the same output as system installed fonts.scale got back to investigate this issue. after taking a look at this a bit, I noticed that the problem is ttmkfdir is going to check the undefined area in the encoding maps. for instance, jisx0201.1976-0.enc.gz has: STARTMAPPING unicode 0x5C 0x00A5 # YEN SIGN 0x7E 0x203E # OVERLINE 0x00A1 0x00DF 0xFF61 ENDMAPPING this defines 65 characters on the map but ttmkfdir tries to check the undefined ranges like between 0x5d and 0x7d, and between 0x7f and 0xa0. this is the unexpected behavior. Created attachment 947548 [details]
proposed patch to avoid checking the undefined character range.
I don't have too much testing with it. there might be a regression perhaps.
I think we need to create some test cases to avoid regression. 1. Generating fonts.scale for all installed fonts. 2. Generating fonts.scale for all installed fonts with updated ttmkfdir. 3. Comparing them for possible regression. How do you find this idea? Oh, wrong patch. the document for the format of the encoding files says, "Codes not listed are assumed to map through the identity (i.e. to the same numerical value). In order to override this default mapping, you may specify a range of codes to be undefined by using an `UNDEFINE' line" So where we need to fix seems the encoding file then. Created attachment 947790 [details]
fix for jisx0201.1976-0.enc.gz
(In reply to Akira TAGOH from comment #8) > Created attachment 947790 [details] > fix for jisx0201.1976-0.enc.gz Thanks, I'm preparing an updated xorg-x11-fonts package with this patch included, and I'll also send it upstream. xorg-x11-fonts-7.5-11.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/xorg-x11-fonts-7.5-11.fc21 Package xorg-x11-fonts-7.5-11.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing xorg-x11-fonts-7.5-11.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-13532/xorg-x11-fonts-7.5-11.fc21 then log in and leave karma (feedback). xorg-x11-fonts-7.5-11.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. Is it possible to backport the fix for f20 too? (In reply to Akira TAGOH from comment #13) > Is it possible to backport the fix for f20 too? Doing it now. xorg-x11-fonts-7.5-10.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/xorg-x11-fonts-7.5-10.fc20 xorg-x11-fonts-7.5-10.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. |