Bug 1009703
| Summary: | Review Request: roboJournal - Keep a journal/diary of day-to-day events in your life | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Will Kraft <pwizard> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | bugs.michael, i, notting, package-review |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-10-28 10:29:30 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Will Kraft
2013-09-18 22:45:44 UTC
Just a note, don't put subpackage information at the bottom.
######################################################################################################################
# RoboJournal Documentation Package SPEC (9/2/13)
%package doc
BuildArch: noarch
Summary: Documentation files for RoboJournal
Requires: qt-assistant, robojournal
%description doc
Documentation (compiled help file and collection file) for RoboJournal %{version}.
%files doc
%{_defaultdocdir}/robojournal/robojournal.qhc
%{_defaultdocdir}/robojournal/robojournal.qch
Put them under %description of main package.
Also qmake-qt4 can be replaced by macro %qmake_qt4
${RPM_BUILD_ROOT} is weird, please use $RPM_BUILD_ROOT or %{buildroot}
%setup -q -n %{name}-%{version} can just be %setup -q
MUST NOT USE %{?_isa} IN BuildRequires!
See: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#BuildRequires_and_.25.7B_isa.7D
> ${RPM_BUILD_ROOT} is weird,
No, the braces are completely okay for shell variables.
I've made the requested changes to my SPEC file and updated the source RPM (see SRPM/SPEC links in the original post). Here is the latest Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6014821 Hopefully all problems have been fixed and the package is ready for sponsorship. As outlined in the private email conversation, please continue in the existing review ticket bug 967659 with a complete pair of "Spec URL:" and "SRPM URL:" lines for the updated package. That would also make it possible to run "fedora-review -b 967659" for letting it perform several helpful checks. *** This bug has been marked as a duplicate of bug 967659 *** |