Bug 1009742

Summary:	Review Request: perl-Term-Menu - print an interactive menu
Product:	[Fedora] Fedora	Reporter:	Chris <chjohnst>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	chjohnst, msuchy, package-review, rc040203
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://search.cpan.org/~dazjorz/Term-Menu-0.09/lib/Term/Menu.pm
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-02-08 13:57:33 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	201449

Description Chris 2013-09-19 03:32:06 UTC

Spec URL: https://www.dropbox.com/s/tbujesxtmxknr39/perl-Term-Menu.spec
SRPM URL: https://www.dropbox.com/s/qtug6gu6xgn0178/perl-Term-Menu-0.09-1.fc18.src.rpm
Description: Simple perl module that makes it easy to print an interactive menu
Fedora Account System Username: cjohnston

Comment 1 Ralf Corsepius 2013-09-19 05:43:08 UTC

* Fails to build in mock.
Please add: 
BuildRequires:  perl(Test::More)

* With the BR: above added, the testsuite skips a test.
Adding 
BuildRequires:  perl(Test::Expect)
causes the skipped test to be run.

* The License: field needs to be
License:        GPL+ or Artistic

* Unless you intent to support EPEL5,
Group: ...
...
BuildRoot:      %{_tmppath}/%{name}-%{version}-build
...
rm -rf $RPM_BUILD_ROOT
can all be removed.

* Macro usage is inconsistent:
%__perl and %{__perl} are both being used.
Please only use one of these (I recommend using %{__perl})

Comment 2 Miroslav Suchý 2015-07-21 14:53:02 UTC

Chris, any progress? Are you still interrested in this package?

Comment 3 Miroslav Suchý 2016-02-08 13:57:33 UTC

No response. Closing as dead review. If you ever want to continue, please resubmit.