| Summary: | [ALL_LANG][Admin Portal] Host tab -> Network Interfaces subtab ->Setup Host Networks -> remove 'menu for' header | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Retired] oVirt | Reporter: | Yuko Katabami <ykatabam> | ||||||
| Component: | ovirt-engine-webadmin | Assignee: | Alona Kaplan <alkaplan> | ||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Yuko Katabami <ykatabam> | ||||||
| Severity: | low | Docs Contact: | |||||||
| Priority: | low | ||||||||
| Version: | 3.4 | CC: | acathrow, alkaplan, ecohen, eng-i18n-bugs, gcheresh, gklein, iheim, knesenko, lijli, lvernia, masayag, mgoldboi, mpavlik, nyechiel, qe-i18n-bugs, Rhev-m-bugs, yeylon | ||||||
| Target Milestone: | --- | Keywords: | CodeChange, i18n, Triaged | ||||||
| Target Release: | 3.4.0 | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | network | ||||||||
| Fixed In Version: | av3 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2014-03-31 12:25:03 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Attachments: |
|
||||||||
Created attachment 800183 [details]
code: NetworkItemPanel.java
confirming that the "Menu for [name]" string is in hard-coded English in NetworkItemPanel.java (see attachment 800183 [details]).
need to localize into a string in the form of "Menu for {0}" (where {0} is the placeholder for the network/bond name) within the web-admin's ApplicationMessages or similar.
Einav, is this menu header actually useful? Might this be a good opportunity to get rid of it? (In reply to Lior Vernia from comment #3) > Einav, is this menu header actually useful? Might this be a good opportunity > to get rid of it? If the users thread [1] concludes that - feel free to close this BZ once the menu's removal is merged upstream. thanks. (In reply to Einav Cohen from comment #4) > (In reply to Lior Vernia from comment #3) > > Einav, is this menu header actually useful? Might this be a good opportunity > > to get rid of it? > > If the users thread [1] concludes that - feel free to close this > BZ once the menu's removal is merged upstream. thanks. [1] http://lists.ovirt.org/pipermail/users/2013-September/016518.html *** Bug 1063896 has been marked as a duplicate of this bug. *** As the thread on the mailing list didn't seem to produce much interest, and due to numerous complaints about the ugliness of the empty menu, I feel it's safe to remove the title of the menu and not show it in case there are no valid actions to perform. Moved by mistake to on_qa. Verified in av3 this is an automated message: moving to Closed CURRENT RELEASE since oVirt 3.4.0 has been released |
Created attachment 799755 [details] Menu for bond0 -- unlocalized Description of problem: "Menu for bond0" is unlocalized and is not pushed to Zanata. Version-Release number of selected component (if applicable):3.3.0-0.22 How reproducible:100% Steps to Reproduce: 1. Login to Admin Portal in any given (non en-US) locale 2. Click on Host tab and select a host in the list. 3. Click on Network Interfaces subtab in the details pane. 4. Click on "Setup Host Networks" action button. 5. Right click one of the eth will show ""Menu for bond0" 6. Also after bonding two nics, when you right click, it also shows ""Menu for bond0" Actual results: "Menu for bond0" is not localized Expected results: "Menu for bond0" should be localized Additional info: