Bug 101029

Summary: bad source code
Product: [Retired] Red Hat Linux Reporter: d.binderman
Component: evolutionAssignee: Jeremy Katz <katzj>
Status: CLOSED UPSTREAM QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 9   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2003-07-28 18:48:06 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description d.binderman 2003-07-28 18:42:21 UTC 
Description of problem:
Hello there,

I've just tried to compile package evolution-1.2.2-4 from Redhat 9.0
with compiler flag -Wall.

icaltimezone.c:195: warning: `return' with no value, in function returning non-void
icaltimezone.c:1606: warning: `return' with no value, in function returning non-void
icaltimezone.c:1620: warning: `return' with no value, in function returning non-void

In each case, returning rubbish off the stack to the caller is deeply
unlikely to be successful.

I think the package would be improved if these warnings were removed
from the next version.



Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
    
Actual results:


Expected results:


Additional info:
Comment 1 Jeremy Katz 2003-07-28 18:48:06 UTC 
Various warnings have been cleaned up in 1.4.x.  It's best to get this fixed by
reporting them upstream (preferably with patches, as that's the way they'll get
fixed the fastest) so that we don't end up carrying extraneous patches.