Bug 1010398
Summary: | Executables that call ifuncs aren't prelinked on s390x | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Richard Sandiford <rsandifo> | ||||
Component: | prelink | Assignee: | Jakub Jelinek <jakub> | ||||
Status: | CLOSED EOL | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | unspecified | Docs Contact: | |||||
Priority: | unspecified | ||||||
Version: | 19 | CC: | jakub, mjw | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | s390x | ||||||
OS: | Unspecified | ||||||
Whiteboard: | |||||||
Fixed In Version: | prelink-0.5.0-3.el7 | Doc Type: | Bug Fix | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2015-02-18 11:14:03 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | 1013801 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Looks correct, committed as r207 to prelink SVN. Will try to add a testcase tomorrow. I've also committed s390 and s390x additions to testsuite/ifunc.h, with r207 reverted all the ifunc* tests FAIL on s390x, with r207 they all pass. This message is a notice that Fedora 19 is now at end of life. Fedora has stopped maintaining and issuing updates for Fedora 19. It is Fedora's policy to close all bug reports from releases that are no longer maintained. Approximately 4 (four) weeks from now this bug will be closed as EOL if it remains open with a Fedora 'version' of '19'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 19 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. Fedora 19 changed to end-of-life (EOL) status on 2015-01-06. Fedora 19 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. |
Created attachment 800586 [details] Suggested fix Description of problem: If an executable has a PLT that calls an ifunc, the prelinker reports an error of the form "Conflict ... not found in any relocation" Version-Release number of selected component (if applicable): prelink-0.5.0-1.fc19.s390x How reproducible: sudo prelink /usr/bin/ls Actual results: prelink: /usr/bin/ls: Conflict 00000b78 not found in any relocation prelink: /usr/bin/ls: Conflict 00000938 not found in any relocation Additional info: This seems to be caused by an early-out in s390_prelink_conflict_rela: if (GELF_R_TYPE (rela->r_info) == R_390_RELATIVE || GELF_R_TYPE (rela->r_info) == R_390_NONE || info->dso == dso) /* Fast path: nothing to do. */ return 0; where "info->dso == dso" means that relocations in the executable are ignored, even if against ifuncs. The attached patch structures the function in a similar way to x86_64. With this, no conflict errors are reported for "prelink -a". The patch makes the same change to 32-bit s390, but I haven't tested that.