Bug 1010435

Summary: NodeJS sample app (server.js) contains a misleading /health route
Product: OpenShift Online Reporter: Nam Duong <nduong>
Component: ContainersAssignee: Jhon Honce <jhonce>
Status: CLOSED CURRENTRELEASE QA Contact: libra bugs <libra-bugs>
Severity: low Docs Contact:
Priority: medium    
Version: 2.xCC: jofernan, yadu
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-10-17 13:30:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Nam Duong 2013-09-20 19:05:51 UTC
Description of problem:
The default nodejs app's server.js contains this route def:
        self.routes['/health'] = function(req, res) {
            res.send('1');
        };

but it's being handled at the proxy so isn't routed to the app's /health handler.  We should remove it as it's confusing for users to try to modify the return value but it's not being reflected on http://$app_url/health

Note that both nodejs-0.6 and nodejs-0.10 contains the same so if we remove/modify this, we need to do so on both cartridge versions.

Comment 1 openshift-github-bot 2013-09-23 21:48:11 UTC
Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/008a0d5b24c2de63a369a1e282447a1e3ce40bf3
Bug 1010435 - /health provided by proxy

Comment 2 Yan Du 2013-09-24 07:05:57 UTC
test on devnev_3816, test with both nodejs-0.6 and nodejs-0.10 app, return "1" when visit the /health page.

move the bug to verified