Bug 1010709

It seems to be a half-baked option upstream IIRC; I did send some things upstream to try to deal with it.  Let me check on the status of those.

-Eric

I thought this commit took care of it, let me see what's going on.

commit 44a2cca35e9292c39bcad38288fdf7a78d6f56af
Author: Eric Sandeen <sandeen>
Date:   Tue Nov 27 12:35:48 2012 -0600

    tune2fs: respect quota config option
    
    If we haven't turned --enable-quota on at config time,
    I don't think tune2fs should know about the feature either.
    
    Today we can actually tune2fs -O quota even if not
    configured on, and then the rest of the tools will
    refuse to touch it:
    
    # tune2fs -O quota /dev/sda1
    # tune2fs -O ^quota /dev/whatever complains
    tune2fs 1.42.3 (14-May-2012)
    tune2fs: Filesystem has unsupported read-only feature(s) while trying to open /dev/sda1
    # fsck /dev/sda1
    fsck from util-linux 2.21.2
    e2fsck 1.42.3 (14-May-2012)
    /dev/sda1 has unsupported feature(s): quota
    e2fsck: Get a newer version of e2fsck!
    
    Ok, so turn it off?
    # tune2fs -O ^quota /dev/whatever complains
    tune2fs 1.42.3 (14-May-2012)
    tune2fs: Filesystem has unsupported read-only feature(s) while trying to open /dev/sda1
    
    Nope.  Debugfs?  Nope.
    
    # debugfs -w /dev/sda1
    debugfs 1.42.3 (14-May-2012)
    /dev/sda1: Filesystem has unsupported read-only feature(s) while opening filesystem
    
    Signed-off-by: Eric Sandeen <sandeen>
    Reported-by: Bert DeKnuydt <Bert.Deknuydt.be>
    Addresses-Red-Hat-Bugzilla: #880596
    Signed-off-by: Theodore Ts'o <tytso>

(In reply to Bert DeKnuydt from comment #0)

> 1. Manual of mkfs.ext4 talks about 'quota': Create quota inodes etc.etc.
>    (unchanged)

Ok, so that's because Ted never picked up my docs patch.  I'll re-ping on that.

It's "only" been on the list since last November, and now I've sent a 2nd ping.  :(

> 2. mkfs.ext4 -O quota /dev/whatever reports
>    "Invalid filesystem option set: quota"
>    (unchanged)

which is correct, since the quota config option is not enabled in fedora

> 3. tune2fs -O quota /dev/whatever does not complain and correctly sets
>    the feature. Slightly changed, as it now prints 'Warning, feature still
>    under development'.  But it does set the option.

I get:

# tune2fs -O quota fsfile 
tune2fs 1.42.7 (21-Jan-2013)
Setting filesystem feature 'quota' not supported.
# rpm -q e2fsprogs
e2fsprogs-1.42.7-2.fc19.x86_64

which is correct.  Are you sure you've tested the right e2fsprogs?

So the other points aren't so important; if we can never set the option, other tools not understanding the option is fine.

It seems half-baked and off by default so in Fedora we should just config it off & pretend it doesn't exist...

> 
> Expected results:
> 
> 1) It should never be possible to set an option, which you cannot unset.

I think I fixed that when you filed the first bug; docs are still wrong though.

> 2) On a meta-level, I'd expect/hope these kind of minor things to be
> addressed 
>    in less than 3 iterations of Fedora.  Otherwise, people might get
> seriously
>    discouraged to report any further bugs ...

I think they were.  Can you re-check?

Hi Eric,

We both are right and wrong ... Took me some time to figure out this one:  

You tried with 'tune2fs -O quota',  'dash Oh',  but I get the
error with 'tune2fs -Q usrquota', 'dash Kjoo'.

So it looks like the fix blocks the quota option when one tries to set
it with '-O quota' but not , but when set with '-Q usrquota', as stated
in the man page. 

[root@fulla tmp]# fallocate -l 10M test.img

[root@fulla tmp]# mkfs.ext4 test.img 
mke2fs 1.42.7 (21-Jan-2013)
test.img is not a block special device.
Proceed anyway? (y,n) y
Discarding device blocks: done                            
Filesystem label=
OS type: Linux
Block size=1024 (log=0)
Fragment size=1024 (log=0)
Stride=0 blocks, Stripe width=0 blocks
2560 inodes, 10240 blocks
512 blocks (5.00%) reserved for the super user
First data block=1
Maximum filesystem blocks=10485760
2 block groups
8192 blocks per group, 8192 fragments per group
1280 inodes per group
Superblock backups stored on blocks: 
        8193

Allocating group tables: done                            
Writing inode tables: done                            
Creating journal (1024 blocks): done
Writing superblocks and filesystem accounting information: done

[root@fulla tmp]# tune2fs -O quota test.img 
tune2fs 1.42.7 (21-Jan-2013)
Setting filesystem feature 'quota' not supported.

[root@fulla tmp]# tune2fs -Q usrquota test.img 
tune2fs 1.42.7 (21-Jan-2013)

Warning: the quota feature is still under development
See https://ext4.wiki.kernel.org/index.php/Quota for more information

--> Now the quota option flag _is_ set, with all associated problems.

So my bug report above is not completely correct: it should have stated 
'-Q usrquota,grpquota'. But the bug itself is still there.

Thanks for picking this up though.

B.

(In reply to Bert DeKnuydt from comment #4)
> Hi Eric,
> 
> We both are right and wrong ... Took me some time to figure out this one:  
> 
> You tried with 'tune2fs -O quota',  'dash Oh',  but I get the
> error with 'tune2fs -Q usrquota', 'dash Kjoo'.
> 
> So it looks like the fix blocks the quota option when one tries to set
> it with '-O quota' but not , but when set with '-Q usrquota', as stated
> in the man page. 

Gah.  Sorry.  Ok, same fix needs to go for that, then.  Stupid knobs.  ;)
I'll send it upstream.

> [root@fulla tmp]# tune2fs -O quota test.img 
> tune2fs 1.42.7 (21-Jan-2013)
> Setting filesystem feature 'quota' not supported.
> 
> [root@fulla tmp]# tune2fs -Q usrquota test.img 
> tune2fs 1.42.7 (21-Jan-2013)

:(

Got it.  I'll fix that up too.  *sigh* why do we have 2 ways to do it.  :(

FWIW, the first bug you filed didn't mention the -Q problem.  ;)

-Eric

Upstream seems fixed, FWIW, after

d82445e tune2fs: more respect for quota config option
f5589f4 mke2fs: remove quota docs if not configured in
44a2cca tune2fs: respect quota config option


[sandeen@sandeen e2fsprogs]$ misc/tune2fs -O quota test.img
tune2fs 1.43-WIP (09-Jul-2014)
Setting filesystem feature 'quota' not supported.
[sandeen@sandeen e2fsprogs]$ misc/tune2fs -Q usrquota test.img
tune2fs 1.43-WIP (09-Jul-2014)
misc/tune2fs: invalid option -- 'Q'

Do you have a particular need for this fix in fedora, or should I just close this upstream/rawhide?

Actually, as of 1.42.11 in rawhide all the options work... hohum.  Seems that I just waited it out.  ;)