Bug 1010728

Created attachment 801337 [details]
File: backtrace

Created attachment 801338 [details]
File: environ

i think in fedora 19 there's no fuse group anymore, so that check in backintime should be removed by deleting the following lines in backintime/common/sshtools.py:

fuse_grp_members = grp.getgrnam('fuse')[3]
if not user in fuse_grp_members:
    raise mount.MountException(...)


flavio

Created attachment 801534 [details]
remove check for fuse group

Created attachment 801535 [details]
apply patch in spec

i attached my proposed fix, please review

thank you,
flavio

Will review later today, thank you for your quick response.

Just ping upstream with response.

(In reply to Christopher Meng from comment #8)
> Just ping upstream with response.

Ping upstream?

(In reply to jwharshaw from comment #9)
> (In reply to Christopher Meng from comment #8)
> > Just ping upstream with response.
> 
> Ping upstream?

Yes, I just get response from upstream, he will look into bugs later.

Maybe we should wait for upstream or just fix it?

Oh you just told the package maintainer? How would we fix the problem our selves for everyone? or do you just mean fix and recompile it individually.

by the way we can get rid of of /home/user/Ubuntu One exclude, since it is Fedora.

OK.

*** Bug 1011272 has been marked as a duplicate of this bug. ***

Created attachment 803229 [details]
Final patch

This should be the final patch I can provide.

Please test.

Christopher, i think the issue here is that the fuse group isn't used anymore in f19, so the exception that now is correctly catched creates an error that is misleading

i guess that check should be removed

Do you steel need reports of testing your patch or i should wait for fix from maintainer?

Unsurprisingly the bug is also present for gnome as well:

Traceback (most recent call last):
  File "/usr/share/backintime/gnome/app.py", line 1017, in on_btn_settings_clicked
    settingsdialog.SettingsDialog( self.config, self.snapshots, self ).run()
  File "/usr/share/backintime/gnome/settingsdialog.py", line 1102, in run
    if not self.validate():
  File "/usr/share/backintime/gnome/settingsdialog.py", line 1246, in validate
    if not self.save_profile():
  File "/usr/share/backintime/gnome/settingsdialog.py", line 945, in save_profile
    mnt.pre_mount_check(mode = mode, first_run = True, **mount_kwargs)
  File "/usr/share/backintime/common/mount.py", line 120, in pre_mount_check
    return tools.pre_mount_check(first_run)
  File "/usr/share/backintime/common/sshtools.py", line 117, in pre_mount_check
    self.check_fuse()
  File "/usr/share/backintime/common/sshtools.py", line 196, in check_fuse
    fuse_grp_members = grp.getgrnam('fuse')[3]
KeyError: 'getgrnam(): name not found: fuse'

Is there any news of the fix being applied upstream?

(In reply to J from comment #18)
Fixed in 1.0.28 version, however this version introduce a new python module which is not in Fedora.

I will fix them soon.

backintime-1.0.28-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/backintime-1.0.28-2.fc19

backintime-1.0.28-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/backintime-1.0.28-2.fc20

Package backintime-1.0.28-2.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing backintime-1.0.28-2.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-22187/backintime-1.0.28-2.fc20
then log in and leave karma (feedback).

backintime-1.0.28-2.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

backintime-1.0.28-2.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.