Bug 1010974

Created attachment 801588 [details]
File: backtrace

Created attachment 801589 [details]
File: dso_list

Created attachment 801590 [details]
File: environ

Probably a missing dep, I hope this is good enough:

commit 3910e8712775e0de2ffd1a9859396f5b051b45a2
Author: Zdenek Pavlas <zpavlas>
Date:   Mon Sep 23 14:36:04 2013 +0200

    yum-plugin-fs-snapshot requires btrfs-progs

diff --git a/yum-utils.spec b/yum-utils.spec
index e22d692..6d6d699 100644
--- a/yum-utils.spec
+++ b/yum-utils.spec
@@ -350,6 +350,7 @@ repo. removes it (and can thus. be reinstalled/downgraded/etc.).
 Summary: Yum plugin to automatically snapshot your filesystems during updates
 Group: System Environment/Base
 Requires: yum >= 3.2.22
+Requires: btrfs-progs
 
 %description -n yum-plugin-fs-snapshot
 When this plugin is installed it will automatically snapshot any

Ah, latest btrfs-progs *does not include btrfsctl*

Whats the point of the fs sync?  Is that needed or just paranoia?
The following appears to work for me.

% diff -u fs-snapshot.py /usr/lib/yum-plugins/fs-snapshot.py
--- fs-snapshot.py	2013-09-23 18:34:37.488541760 -0400
+++ /usr/lib/yum-plugins/fs-snapshot.py	2013-09-23 18:26:46.497672471 -0400
-    p = Popen(["/sbin/btrfsctl", "-c", mntpnt], stdout=PIPE, stderr=PIPE)
-    err = p.wait()
-    if err:
-        return 1
-    p = Popen(["/sbin/btrfsctl", "-s", snapname, mntpnt], stdout=PIPE, stderr=PIPE)
+    #p = Popen(["/sbin/btrfsctl", "-c", mntpnt], stdout=PIPE, stderr=PIPE)
+    #err = p.wait()
+    #if err:
+    #    return 1
+    p = Popen(["/sbin/btrfs", "subvolume", "snapshot", mntpnt, snapname], stdout=PIPE, stderr=PIPE)

It depends.. if the block cache is implemented on top of lvm (and it probably is, because that'd make it a bit faster), then we definitely *should* sync before snapshotting. All examples I've googled so far include the sync, so let's keep it.

Could you just change "btrfsctl -c <mntpnt>" to "btrfs filesystem sync <mntpnt>"? If that works, I'd merge your patch.  Thanks!

Ok, here is the patch as requested, with function doc updated as well.


% diff -u fs-snapshot.py /usr/lib/yum-plugins/fs-snapshot.py
--- fs-snapshot.py	2013-09-23 18:34:37.488541760 -0400
+++ /usr/lib/yum-plugins/fs-snapshot.py	2013-09-24 10:39:52.993241471 -0400
@@ -198,9 +198,8 @@
     """
     Runs the commands necessary for a snapshot.  Basically its just
 
-    btrfsctl -c /dir/to/snapshot    #this syncs the fs
-    btrfsctl -s /dir/to/snapshot/${snapshot_tag}
-                /dir/to/snapshot
+    btrfs filesystem sync /dir/to/snapshot    #this syncs the fs
+    btrfs subvolume snapshot /dir/to/snapshot /dir/to/snapshot/${snapshot_tag}
 
     and then we're done.
     """
@@ -212,11 +211,11 @@
 
     snapname = mntpnt + snapshot_tag
     conduit.info(1, "fs-snapshot: snapshotting " + mntpnt + ": " + snapname)
-    p = Popen(["/sbin/btrfsctl", "-c", mntpnt], stdout=PIPE, stderr=PIPE)
+    p = Popen(["/sbin/btrfs", "filesystem", "sync", mntpnt], stdout=PIPE, stderr=PIPE)
     err = p.wait()
     if err:
         return 1
-    p = Popen(["/sbin/btrfsctl", "-s", snapname, mntpnt], stdout=PIPE, stderr=PIPE)
+    p = Popen(["/sbin/btrfs", "subvolume", "snapshot", mntpnt, snapname], stdout=PIPE, stderr=PIPE)
     err = p.wait()
     if err:
         return 1

yum-utils-1.1.31-18.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/yum-utils-1.1.31-18.fc19

Package yum-utils-1.1.31-18.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing yum-utils-1.1.31-18.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-17856/yum-utils-1.1.31-18.fc19
then log in and leave karma (feedback).

yum-utils-1.1.31-18.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

*** Bug 1013377 has been marked as a duplicate of this bug. ***