Bug 1011049

Summary: spacewalk-splice-tool: network info with ';' causes error
Product: [Retired] Subscription Asset Manager Reporter: Chris Duryee <cduryee>
Component: SpliceAssignee: Splice Developers <splice-devel>
Status: CLOSED WONTFIX QA Contact: mkovacik
Severity: medium Docs Contact:
Priority: medium    
Version: 1.3CC: chrobert, mmello, pmutha, xdmoon
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-10-04 20:01:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 971511    

Description Chris Duryee 2013-09-23 14:26:03 UTC
Description of problem:

If the network info for a system (as read from spacewalk-report splice-export) contains a ';' character, sst will fail.

Version-Release number of selected component (if applicable): 0.46


How reproducible: every time


Steps to Reproduce:
1. create a system in sat 5.6 with a network interface like ";vdsmdummy;"
2. run spacewalk-splice-checkin --spacewalk-sync

Actual results:

Traceback (most recent call last):
  File "/usr/bin/spacewalk-splice-checkin", line 100, in <module>
    checkin.main(opts)
  File "/usr/lib/python2.6/site-packages/spacewalk_splice_tool/checkin.py", line 225, in main
    spacewalk_sync(options)
  File "/usr/lib/python2.6/site-packages/spacewalk_splice_tool/checkin.py", line 171, in spacewalk_sync
    consumers.extend(dt.transform_to_consumers(system_details))
  File "/usr/lib/python2.6/site-packages/spacewalk_splice_tool/transforms.py", line 83, in transform_to_consumers
    facts_data = facts.translate_sw_facts_to_subsmgr(details)
  File "/usr/lib/python2.6/site-packages/spacewalk_splice_tool/facts.py", line 27, in translate_sw_facts_to_subsmgr
    facts.update(network_facts(system_details))
  File "/usr/lib/python2.6/site-packages/spacewalk_splice_tool/facts.py", line 110, in network_facts
    (iface, addrmask, hwaddr) = n.split()
ValueError: need more than 0 values to unpack


Expected results: successful run


Additional info: This might require a change to spacewalk-reports to escape the ';', and to spacewalk-splice-tool to handle escacped ';' chars.

Comment 3 Xixi 2014-10-24 02:56:37 UTC
Temporary workaround is to use Satellite API to list all systems[1] then find the system with a network interface[2] with ";" in its name, then change the name to remove the ";".

[1] https://access.redhat.com/documentation/en-US/Red_Hat_Satellite/5.6/html/API_Overview/sect-system-listSystems.html
[2] https://access.redhat.com/documentation/en-US/Red_Hat_Satellite/5.6/html/API_Overview/sect-system-getNetworkDevices.html

Put this in KCS https://access.redhat.com/solutions/1243013.

Xixi