| Summary: | Missing port range validation for custom ports settings | ||
|---|---|---|---|
| Product: | [JBoss] JBoss Enterprise Application Platform 6 | Reporter: | Petr Kremensky <pkremens> |
| Component: | Installer | Assignee: | Francisco Canas <fcanas> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Petr Kremensky <pkremens> |
| Severity: | medium | Docs Contact: | Russell Dickenson <rdickens> |
| Priority: | unspecified | ||
| Version: | 6.2.0 | CC: | fcanas, myarboro, thauser |
| Target Milestone: | ER3 | Keywords: | Regression |
| Target Release: | EAP 6.2.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-12-15 16:12:18 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Petr Kremensky
2013-09-23 14:27:42 UTC
I have added port range validation for all of the sockets that were missing it. One thing to note: There are several ports with default values of 0. These obviously will not pass validation. Are there better default values that could be assigned to these so that the user isn't forced to manually change them? See this commit for details: http://git.app.eng.bos.redhat.com/?p=jbossas-installer.git;a=commit;h=26b15938a75a3863640405a3fbbeb75a459d0088 Ports with assigned value 0 aren't used at all. eg. modcluster is using only multicast-port. <socket-binding name="modcluster" port="0" multicast-address="224.0.1.105" multicast-port="23364"/> We can either remove them completely (each port with value 0 shouldn't be configurable and should be left to 0 by default), disable them, or left them to 0 as it is now. Disabling the non-user-configurable ports in the socket panels would require an extension to izpack, and leaving them with a default value of '0' would require removing their validation which means the user would be able to set them to any arbitrary value. So instead, I have removed them from their respective panels. Details in the commit: http://git.app.eng.bos.redhat.com/?p=jbossas-installer.git;a=commit;h=415b1009f17d04026fc0f6193078131de1bb1c41 Changed how the post install jobs connect to server (domain does not use port offset, while standalone does). Specifying a port offset no longer leads to failure in the post-install panel. See commit for details: http://git.app.eng.bos.redhat.com/?p=jbossas-installer.git;a=commit;h=31f485ae564fdf6a60a1e10b127f684f8bbcf19d NOTE: The post-install panel currently doesn't support user-specified management ports for all of the various configurations of the standalone server (regular, ha, full). So manually changing the management port for the ha and full configurations will lead to failure in the post-install. This support will added by the next ER. Please disregard previous comment about port offsets. It was meant for https://bugzilla.redhat.com/show_bug.cgi?id=1009421. Please move all BZs ready for verification to ON_QA once the target milestone was released, thanks. Verified on EAP 6.2.0.ER3 |