Bug 1011116
| Summary: | Update NIC doesn't actually update the NIC if only network is passed (without passing VNIC profile) | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Virtualization Manager | Reporter: | tgeft |
| Component: | ovirt-engine-restapi | Assignee: | Moti Asayag <masayag> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Meni Yakove <myakove> |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 3.3.0 | CC: | acathrow, bazulay, iheim, mpavlik, nobody, oramraz, Rhev-m-bugs, yeylon |
| Target Milestone: | --- | ||
| Target Release: | 3.3.0 | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | network | ||
| Fixed In Version: | is19 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | Bug | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Network | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1026487 | ||
works in is19 Closing - RHEV 3.3 Released Closing - RHEV 3.3 Released Closing - RHEV 3.3 Released |
Description of problem: When updating a NIC and just passing the network as the parameter to be changed, the update appears to happen with no error although the NIC doesn't get updated at all. After the introduction of VNIC profiles, the correct way to update a NIC's network is to update its VNIC profile but for backward compatibility updating the network should be supported as well. Version-Release number of selected component (if applicable): is15 How reproducible: 100% Steps to Reproduce: 1. Prepare a NIC with some network on a VM. 2. Send an update NIC request with a different network as the parameter as follows: PUT request content is -- url:/api/vms/09d3adf7-aaeb-416b-af57-acb18643120a/nics/f2990cc5-d452-4b76-ae5c-16e20b5bc251 body: <nic> <network> <name>sw1</name> </network> </nic> Actual results: The update appears to go through fine as shown on the engine log: [org.ovirt.engine.core.bll.network.vm.UpdateVmInterfaceCommand] (ajp-/127.0.0.1:8702-2) Running command: UpdateVmInterfaceCommand internal: false. Entities affected : ID: 09d3adf7-aaeb-416b-af57-acb18643120a Type: VM, ID: c3c98e39-f11a-4efe-aa6b-8fc23d49d2ba Type: VnicProfile 2013-09-23 18:55:58,190 INFO [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (ajp-/127.0.0.1:8702-2) Correlation ID: 2bc7e527, Call Stack: null, Custom Event ID: -1, Message: Interface nic1 (VirtIO) was updated for VM VMTest1. (User: admin@internal) However in the response the NIC keeps the profile it had and so stays on the same network. Expected results: The NIC's profile should be updated with a profile that doesn't contain port mirroring for the provided network (if such a profile exists, otherwise an error should be returned). Additional info: The correct behavior for choosing a profile for the NIC when just the network is provided is shown by addNIC action.