Bug 1011183

Summary: Review Request: sisu-mojos - Sisu plugin for Apache Maven
Product: [Fedora] Fedora Reporter: Mikolaj Izdebski <mizdebsk>
Component: Package ReviewAssignee: gil cattaneo <puntogil>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: notting, puntogil
Target Milestone: ---Flags: puntogil: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-11-13 12:39:59 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
review notes none

Description Mikolaj Izdebski 2013-09-23 17:49:09 UTC
Spec URL: http://mizdebsk.fedorapeople.org/review/sisu-mojos/sisu-mojos.spec
SRPM URL: http://mizdebsk.fedorapeople.org/review/sisu-mojos/sisu-mojos-0.0.0-0.1.M5.fc21.src.rpm
Description: The Sisu Plugin for Maven provides mojos to generate
META-INF/sisu/javax.inject.Named index files for the Sisu container.
Fedora Account System Username: mizdebsk

Comment 1 gil cattaneo 2013-09-23 19:46:19 UTC
Created attachment 801865 [details]
review notes

all seem ok except for
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/java/sisu-mojos
please, fix unowned directory before import

approved

Comment 2 Mikolaj Izdebski 2013-09-24 09:48:50 UTC
Thank you for the review.
I will fix unowned directory at SCM import.

Comment 3 Mikolaj Izdebski 2013-09-24 09:49:26 UTC
New Package SCM Request
=======================
Package Name: sisu-mojos
Short Description: Sisu plugin for Apache Maven
Owners: mizdebsk msrb sochotni
Branches: f20
InitialCC: java-sig

Comment 4 Gwyn Ciesla 2013-09-24 12:25:42 UTC
Git done (by process-git-requests).