| Summary: | Wrong theme for hover help in eclipse. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Severin Gehwolf <sgehwolf> | ||||
| Component: | eclipse | Assignee: | Alexander Kurtakov <akurtako> | ||||
| Status: | CLOSED EOL | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 21 | CC: | akurtako, andjrobins, jerboaa, mbenitez, mstahl, overholt, rgrunber, swagiaal | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2015-12-02 02:58:19 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Attachments: |
|
||||||
Perhaps this is a duplicate of bug 989497. I forgot to mention that it works fine if I omit "SWT_GTK3=1". The issue is a bit complicated. I proposed fixing it in the same way it was fixed on GTK2, but even that approach was flawed (https://bugs.eclipse.org/bugs/show_bug.cgi?id=439884 ). After some discussion, I think the best we can do in the short-term, is to hard-code the COLOR_INFO_* values to something that works well with the Adwaita theme. This is basically what is done on cocoa http://git.eclipse.org/c/platform/eclipse.platform.swt.git/tree/bundles/org.eclipse.swt/Eclipse%20SWT/cocoa/org/eclipse/swt/widgets/Display.java#n1821 upstream. this has become a *bit* more annoying with Fedora 22 because apparently GTK3 is now the default. in CDT hovering over a variable i see black background in the popup, with the highlighted line having a very light grey background and white text - unreadable. there was a similar bug with the GTK2 theme back in the day and it was fixed somehow: https://bugzilla.redhat.com/show_bug.cgi?id=903352 the obvious workaround SWT_GTK3=0 does not work for me; apparently something overrides it? i can see in /proc/*/environ that SWT_GTK3=0 for "eclipse" but SWT_GTK3=1 for "java" process. ...and this is a potential duplicate: https://bugzilla.redhat.com/show_bug.cgi?id=1196736 package nvrs: gtk3-3.16.5-1.fc22.x86_64 eclipse-rse-3.7.0-1.fc22.noarch eclipse-remote-1.1.1-1.fc22.noarch eclipse-jgit-3.7.1-2.fc22.noarch eclipse-ptp-rdt-xlc-8.1.1-2.fc22.noarch eclipse-platform-4.4.2-6.fc22.x86_64 eclipse-pde-4.4.2-6.fc22.x86_64 eclipse-cdt-parsers-8.6.0-2.fc22.x86_64 eclipse-filesystem-1.0-3.fc22.x86_64 eclipse-equinox-osgi-4.4.2-6.fc22.x86_64 eclipse-ptp-rdt-8.1.1-2.fc22.noarch eclipse-ecf-core-3.10.0-1.fc22.x86_64 eclipse-valgrind-3.2.0-1.fc22.noarch eclipse-jdt-4.4.2-6.fc22.x86_64 eclipse-cdt-8.6.0-2.fc22.x86_64 eclipse-emf-core-2.10.2-1.fc22.x86_64 eclipse-ptp-8.1.1-2.fc22.x86_64 eclipse-linuxtools-3.2.0-1.fc22.noarch eclipse-emf-runtime-2.10.2-1.fc22.noarch eclipse-swt-4.4.2-6.fc22.x86_64 (In reply to comment #4) > the obvious workaround SWT_GTK3=0 does not work for me; > apparently something overrides it? i can see in /proc/*/environ > that SWT_GTK3=0 for "eclipse" but SWT_GTK3=1 for "java" process. Can you try modifying the value given to '--launcher.GTK_version' in /etc/eclipse.ini (from 3) to 2, and see if that improves things. I'm not sure if that environment variable works anymore. (In reply to Roland Grunberg from comment #5) > (In reply to comment #4) > > the obvious workaround SWT_GTK3=0 does not work for me; > > apparently something overrides it? i can see in /proc/*/environ > > that SWT_GTK3=0 for "eclipse" but SWT_GTK3=1 for "java" process. > > Can you try modifying the value given to '--launcher.GTK_version' in > /etc/eclipse.ini (from 3) to 2, and see if that improves things. I'm not > sure if that environment variable works anymore. yes, that switches to GTK 2, which works nicely for me. This message is a reminder that Fedora 21 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 21. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '21'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 21 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. Fedora 21 changed to end-of-life (EOL) status on 2015-12-01. Fedora 21 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. |
Created attachment 802122 [details] screenshot showing white-on-back theme for javadoc hover help. Description of problem: I have "eclipse" aliased to "SWT_GTK3=1 eclipse". When I hover over javadoc, I see this ugly white-on-black theme (over black on white). Version-Release number of selected component (if applicable): eclipse-swt-4.3.0-4.fc19.x86_64 How reproducible: Always. Steps to Reproduce: 1. SWT_GTK3=1 eclipse on F19 + gnome 3 2. Hover over some method which has javadoc Actual results: No nice theming :) Expected results: Better support for theming using GTK3 backend. Additional info: I'm attaching a screenshot illustrating the issue. It most probably outside of eclipse (adwaita-gtk3-theme perhaps?). Perhaps it makes sense to port theming fixing from adwaita-gtk2-theme to the 3 equivalent?