Bug 1011763

You shouldn't use %define.

Thanks Christopher - fixed.

Spec URL: http://fedorapeople.org/~codeblock/packages/mozilla-fira-fonts/mozilla-fira-fonts.spec
SRPM URL: http://fedorapeople.org/~codeblock/packages/mozilla-fira-fonts/mozilla-fira-fonts-0.20130925-2.fc19.src.rpm

Can you add font information to https://fedoraproject.org/wiki/Category:In-progress_fonts by creating new wiki page?

1) simple way to find font information is to use following command
otfinfo -i *.otf | grep Version

so you got version as 2.001 but as some upstream keep releasing snapshots either adding date in archive name or publishes date on upstream URL, you need to use release tag as 
0.%{X}.%{alphatag}

this way even if upstream fails to bump the release in font file and keep releasing updated tarballs, package can be updated.

your package n-v-r then mozilla-fira-fonts-2.001-0.1.20130925.fc19

2) cp commands should preserve timestamps of files being copied from source archive. Use "cp -p"

3) if this package is only for Fedora then remove Group tag

Thanks! I've made those changes. I will do the wiki page shortly.

New URLs:

Spec URL: http://fedorapeople.org/~codeblock/packages/mozilla-fira-fonts/mozilla-fira-fonts.spec
SRPM URL: http://fedorapeople.org/~codeblock/packages/mozilla-fira-fonts/mozilla-fira-fonts-2.001-0.1.20130925.fc20.src.rpm

I added the wiki page, but I'm not entirely sure what to put for some of the fields (in the table which I copied from other pages in that category).

https://fedoraproject.org/wiki/Mozilla_Fira_fonts

Feel free to edit it, and I apologize if I got any of it wrong.

1) Following comment should be before Source0: line
# Upstream tarball is not versioned. See the "Downloads" section of %%{url}.

also add upstream does not provide direct download link

2) Add some comment for Source3:, from where you got the license file or its information 
OR you can say its standard OFL license text included as fira.LICENSE file

3) Group: tag is not necessary if you are planning this package only for Fedora releases. Please remove it.

4) Add the correct changelog

I have added some information to wiki page of this font.

Hah, whoops - missed the Group tag on the subpackages.
Fixed that and made the other corrections.

Spec URL: http://fedorapeople.org/~codeblock/packages/mozilla-fira-fonts/mozilla-fira-fonts.spec
SRPM URL: http://fedorapeople.org/~codeblock/packages/mozilla-fira-fonts/mozilla-fira-fonts-2.001-0.2.20130925.fc20.src.rpm

only last thing is keep same summary wording in spec as well as in this bug title summary.

APPROVED.

Thanks - I will make that last change to the spec when I import.

New Package SCM Request
=======================
Package Name: mozilla-fira-fonts
Short Description: Mozilla's Fira font
Owners: codeblock
Branches: f19 f20
InitialCC:

Git done (by process-git-requests).

mozilla-fira-fonts-2.001-0.2.20130925.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/mozilla-fira-fonts-2.001-0.2.20130925.fc20

mozilla-fira-fonts-2.001-0.2.20130925.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/mozilla-fira-fonts-2.001-0.2.20130925.fc19

mozilla-fira-fonts-2.001-0.2.20130925.fc19 has been pushed to the Fedora 19 testing repository.

mozilla-fira-fonts-2.001-0.2.20130925.fc19 has been pushed to the Fedora 19 stable repository.

mozilla-fira-fonts-2.001-0.2.20130925.fc19 has been pushed to the Fedora 19 stable repository.

mozilla-fira-fonts-2.001-0.2.20130925.fc20 has been pushed to the Fedora 20 stable repository.

Package Change Request
======================
Package Name: mozilla-fira-fonts
Branches: f19 f20 devel
InitialCC: fonts-sig

I'd like the Fonts SIG to be notified of changes to this package in all active branches.

Complete.