Bug 1011850
| Summary: | Weak password message looks weird when clicking “Done” once: “You have provided a weak password: None. Press done to use anyway” | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mike FABIAN <mfabian> | ||||
| Component: | anaconda | Assignee: | David Shea <dshea> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 20 | CC: | anaconda-maint-list, dshea, g.kaviyarasu, jonathan, mkolman, sbueno, vanmeeuwen+fedora | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | anaconda-20.21-1.fc20 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2013-10-04 01:54:56 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
anaconda-20.21-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/anaconda-20.21-1.fc20 Package anaconda-20.21-1.fc20, pykickstart-1.99.41-1.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing anaconda-20.21-1.fc20 pykickstart-1.99.41-1.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-17921/pykickstart-1.99.41-1.fc20,anaconda-20.21-1.fc20 then log in and leave karma (feedback). anaconda-20.21-1.fc20, pykickstart-1.99.41-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 802662 [details] password-weak-none-error-message.png When installing Fedora 20 Alpha (release), when the installation is running, one can add a user (and/or set the root password). When entering a weak password and clicking “Done” once, one sees the message: “You have provided a weak password: None. Press done to use anyway” The “None.” looks quite weird to me. Looking at the python code: user.py line 546: if pwstrength < 2: # If Done has been clicked twice, waive the check if self._waivePasswordClicks > 1: return None elif self._waivePasswordClicks == 1: return _("You have provided a weak password: %s. " " Press Done again to use anyway.") % self._pwq_error else: error = _("The password you have provided is weak") if self._pwq_error: error += ": %s. " % self._pwq_error else: error += ". " error += _("You will have to press Done twice to confirm it.") return error it seems that self._pwq_error is “None”, which probably means that there was no error. But displaying that Python value “None” to the user seems useless and confusing.