Bug 1012315

Summary: reporting pkgdetails for packages that are not installed
Product: [Fedora] Fedora Reporter: Martin Cermak <mcermak>
Component: beakerlibAssignee: Petr Muller <pmuller>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: ohudlick, pmuller, psplicha
Target Milestone: ---Keywords: Patch
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard: Release
Fixed In Version: beakerlib-1.9-3.fc20 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1108309 (view as bug list) Environment:
Last Closed: 2014-07-30 06:57:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1116308, 1116317    
Attachments:
Description Flags
proposed patch none

Description Martin Cermak 2013-09-26 09:18:06 UTC 
Created attachment 803307 [details]
proposed patch

If pkgdetails (in sense of bug 772178) are requested (e.g. export  PKGNVR=systemtap,devtoolset-2-systemtap,kernel) for a package that is not really installed, you may end up with a journal like this:

<package>unknown</package>
<pkgdetails>unknown is not installed!</pkgdetails>
<pkgdetails>systemtap-2.3-1.el6.x86_64 </pkgdetails>
<pkgdetails>devtoolset-2-systemtap is not installed!</pkgdetails><pkgdetails>kernel-2.6.32-419.el6.x86_64 </pkgdetails>

Note that <package>unknown</package> is because of PACKAGE="systemtap" not being set, which is also worth of our attention since one might not be willing to set it in case of testing collections.

I think that <pkgdetails>devtoolset-2-systemtap is not installed!</pkgdetails> is not correct. I' expect a package NVR there, not an error message. I suggest to use a dedicated mark for missing packages like <pkgnotinstalled> or some such. And also why not omit "unknown"? So I'm proposing a patch (attached) that makes the journal look like:

<package>unknown</package>
<pkgdetails>systemtap-2.3-1.el6.x86_64 </pkgdetails>
<pkgnotinstalled>devtoolset-2-systemtap</pkgnotinstalled>
<pkgdetails>kernel-2.6.32-419.el6.x86_64 </pkgdetails>

Which I'd prefer.
Comment 1 Martin Cermak 2013-09-28 14:14:51 UTC 
Another consequence is kind of meaningless test protocol:

::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
:: [   LOG    ] :: TEST PROTOCOL
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

[ ... ] 

:: [   LOG    ] :: Installed:    : unknown is not installed!

[ ... ]
Comment 2 Petr Muller 2013-09-30 15:17:04 UTC 
Seems good, thanks for the patch!
Comment 3 Petr Muller 2014-06-11 17:03:10 UTC 
https://git.fedorahosted.org/cgit/beakerlib.git/commit/?id=2ef8817ebb78bcbbc6499760b113fb3fba42d480
Comment 4 Fedora Update System 2014-06-17 13:42:06 UTC 
beakerlib-1.9-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/beakerlib-1.9-1.fc20
Comment 5 Fedora Update System 2014-06-17 23:29:38 UTC 
Package beakerlib-1.9-1.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing beakerlib-1.9-1.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-7442/beakerlib-1.9-1.fc20
then log in and leave karma (feedback).
Comment 6 Fedora Update System 2014-07-02 08:01:48 UTC 
beakerlib-1.9-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/beakerlib-1.9-2.fc20
Comment 7 Dalibor Pospíšil 2014-07-04 08:51:00 UTC 
Please consider the package fixing this bug available in Fedora stable repos once bz1116308 is closed and RHEL stable repos once bz1116317 is closed.

Fixed in:
beakerlib-1.9-2.fc19
beakerlib-1.9-2.fc20
beakerlib-1.9-2.fc21
beakerlib-1.9-3.el5
beakerlib-1.9-2.el6
beakerlib-1.9-2.el7
Comment 8 Fedora Update System 2014-07-17 13:15:58 UTC 
beakerlib-1.9-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/beakerlib-1.9-3.fc20
Comment 9 Fedora Update System 2014-07-30 06:57:32 UTC 
beakerlib-1.9-3.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.