Bug 1012337
Summary: | Review Request: cajun-jsonapi - cross-platform C++ header library for JSON | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Daniel Pocock <daniel> |
Component: | Package Review | Assignee: | Peter Lemenkov <lemenkov> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | daniel, lemenkov |
Target Milestone: | --- | Flags: | lemenkov:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2016-03-03 16:28:37 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Daniel Pocock
2013-09-26 10:04:23 UTC
I'll review it. REVIEW: Legend: + = PASSED, - = FAILED, 0 = Not Applicable + rpmlint is almost silent sulaco ~/rpmbuild/SPECS: rpmlint ../RPMS/ppc/cajun-jsonapi-devel-2.0.3-1.fc21.ppc.rpm ../SRPMS/cajun-jsonapi-2.0.3-1.fc21.src.rpm cajun-jsonapi-devel.ppc: W: wrong-file-end-of-line-encoding /usr/share/doc/cajun-jsonapi-devel/Readme.txt cajun-jsonapi-devel.ppc: W: wrong-file-end-of-line-encoding /usr/share/doc/cajun-jsonapi-devel/ReleaseNotes.txt ^^^ Please convert these files to UTF-8. 2 packages and 0 specfiles checked; 0 errors, 2 warnings. sulaco ~/rpmbuild/SPECS: + The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. +/- The package almost meets the Packaging Guidelines. I see few things that should be improved. 1. First of all - this package should be marked as noarch since it doesn't depend on any arch-specific entity. So please remove %define debug_package %{nil} and add the following line instead: BuildArch: noarch 2. Also you may remove unneeded "%defattr(-,root,root,-)" in the %files section. It becomes obsolete since Fedora Core 6 or RHEL 5. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The License field in the package spec file matches the actual license. + The spec file is written in American English. + The spec file for the package is legible. + The package successfully compiles and builds into binary rpms on at least one primary architecture. + All build dependencies are listed in BuildRequires. 0 No need to handle locales. 0 No shared library files. + The package does NOT bundle copies of system libraries. + The package is not designed to be relocatable. + The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. + The package consistently uses macros. + The package contains code, or permissible content. 0 No extremely large documentation files. + Anything, the package includes as %doc, does not affect the runtime of the application. 0 No header files. 0 No static libraries. 0 No pkgconfig(.pc) files. 0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1). + The package does NOT contain any .la libtool archives. 0 Not a GUI application. + The package does not own files or directories already owned by other packages. + All filenames in rpm packages are valid UTF-8. So please fix/comment the issues mentioned above and I'll finish it. (In reply to Peter Lemenkov from comment #2) > REVIEW: > > Legend: + = PASSED, - = FAILED, 0 = Not Applicable > > + rpmlint is almost silent > > sulaco ~/rpmbuild/SPECS: rpmlint > ../RPMS/ppc/cajun-jsonapi-devel-2.0.3-1.fc21.ppc.rpm > ../SRPMS/cajun-jsonapi-2.0.3-1.fc21.src.rpm > cajun-jsonapi-devel.ppc: W: wrong-file-end-of-line-encoding > /usr/share/doc/cajun-jsonapi-devel/Readme.txt > cajun-jsonapi-devel.ppc: W: wrong-file-end-of-line-encoding > /usr/share/doc/cajun-jsonapi-devel/ReleaseNotes.txt > > ^^^ Please convert these files to UTF-8. I mean Unix. Unix line endings. Ok, I see that Daniel fixed everything. I don't see any other issues so this package is APPROVED. Ping, Daniel! You didn't requested fedora-cvs flag yet. Sorry, I didn't realise, the flag is set to "?" now (In reply to Daniel Pocock from comment #6) > Sorry, I didn't realise, the flag is set to "?" now Daniel, that's still not enough :). You need to fill this template and post it as well: https://fedoraproject.org/wiki/Package_SCM_admin_requests#New_Packages New Package SCM Request ======================= Package Name: cajun-jsonapi Short Description: cross-platform C++ header library for JSON Owners: pocock Branches: f19 f20 el6 InitialCC: Git done (by process-git-requests). Daniel, it looks that you forgot to submit cajun-jsonapi package for EL6: https://admin.fedoraproject.org/updates/search/cajun-jsonapi I had tried to but I get an error from https://admin.fedoraproject.org/updates/new/ it says "cajun-jsonapi-2.0.3-1.el6 not tagged as an update candidate" Do I need to make some extra tag? It already appears to be tagged. Do I need to wait for it to be stable in Fedora before it can propagate to EPEL or do I need to request some additional approval for it? It is in the repository for EPEL6 http://pkgs.fedoraproject.org/cgit/cajun-jsonapi.git/tree/?h=el6 and it is built on EPEL6: http://koji.fedoraproject.org/koji/buildinfo?buildID=489563 Ok, closing this - the package was built long time ago. |