Bug 1012389

Summary: changes to retention tag name are not persisted, impossible to change tag name
Product: [Retired] Beaker Reporter: wangjing <jingwang>
Component: web UIAssignee: Dan Callaghan <dcallagh>
Status: CLOSED CURRENTRELEASE QA Contact: tools-bugs <tools-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: developCC: aigao, asaha, dcallagh, llim, qwan, rmancy
Target Milestone: 0.16   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-03-17 03:01:53 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description wangjing 2013-09-26 11:51:03 UTC 
Description of problem:
can't update Retention tag but return ok

Version-Release number of selected component (if applicable):
Version 0.15.0rc1 beaker-devel

How reproducible:
always

Steps to Reproduce:
1. admin login.
2. page: Admin->Retention tags
3. click to open one tag, and update the Tag name.
4. click button 'Save'

Actual results:
return ok, but the tag name was not updated.

Expected results:
hope the feature works, or make the Tag value cannot be updated if it is by define.

Additional info:
Comment 2 Dan Callaghan 2013-09-27 04:04:24 UTC 
As far as I can see this has never actually worked, so not a regression.
Comment 3 Nick Coghlan 2013-09-27 05:58:05 UTC 
Turns out there's an underlying issue in the database model that means this can't be fixed in a maintenance release - bumping to 0.16
Comment 4 Dan Callaghan 2013-09-27 06:43:50 UTC 
Patch to make tag name changes take effect:

http://gerrit.beaker-project.org/2309

Patch to allow "expire in days" field to also be edited:

http://gerrit.beaker-project.org/2310

The latter is important for example if the admin changes the "60Days" tag to "90Days".
Comment 6 wangjing 2014-02-18 09:58:37 UTC 
tested on beaker-devel( build 0.15.4.git.110.c0912fb)-->partly fail

1. modify the Retention tag name with valid/invalid value.-->pass
2. modify the "expire in days" field-->fail
steps: 
1)visit one Retention tag page and change the value in "expire in days" field
2)click save.

Actual resutls:
red message 'Retention tag already exists' under 'Tag' field, and failed to modify value in "expire in days" field

Expected results:
modifying the "expire in days" field should succeed.
Comment 7 Dan Callaghan 2014-02-20 07:11:27 UTC 
Fix for editing existing tags (without renaming them):
http://gerrit.beaker-project.org/2826
Comment 10 Dan Callaghan 2014-03-17 03:01:53 UTC 
Beaker 0.16.0 has been released.