Bug 1012497

Summary:	swift: swift delete <container> should have a warning like rm unless used with --force
Product:	Red Hat OpenStack	Reporter:	Dafna Ron <dron>
Component:	python-swiftclient	Assignee:	RHOS Maint <rhos-maint>
Status:	CLOSED UPSTREAM	QA Contact:	Martina Kollarova <mkollaro>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.0	CC:	abaron, dallan, derekh, hateya, jruzicka, ncredi, yeylon, zaitcev
Target Milestone:	---	Keywords:	Improvement, MoveUpstream
Target Release:	5.0 (RHEL 7)
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:		Environment:	dron: rhos-4.0
Last Closed:	2013-10-31 10:42:57 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Dafna Ron 2013-09-26 14:49:48 UTC

Description of problem:

currently if you run swift delete <container> than the container and all files will be deleted. 
I think that much like the rm command we should add a --force or rf so that either a warning appears or user knows what they are doing and adds the --force. 

Version-Release number of selected component (if applicable):

openstack-swift-1.8.0-6.el6ost.noarch

How reproducible:

100%

Steps to Reproduce:
1. create a container with several files 
2. run: swift delete <container> 
3.

Actual results:

container and all files will be removed without a warning 

Expected results:

we should not remove a whole container with no warning or a --force added (much like rm command) 

Additional info:

Comment 1 Dafna Ron 2013-09-26 14:53:45 UTC

https://bugs.launchpad.net/swift/+bug/1231495

Comment 2 Pete Zaitcev 2013-09-26 16:20:09 UTC

Isn't it a matter of personal preference? We have this awful redhattism
of aliases for rm/cp/mv for root, which I always delete from /root/.bashrc.
I suppose it sets a precedent, but if we do the same for swift(1), then
we draw the same downsides -- only worse because there's no separate
mode for scripting in Swift client. You don't want everyone to have separate
scripts for RHOS, do you?

Comment 3 Dafna Ron 2013-09-26 16:28:43 UTC

as you said, this is a personal preferences but RH releases do go out with aliases for rm and so on and I don't think that all people delete these preferences. 
in facet, I worked in support for production servers where we added additional protection for some things since someone running with root or sudo user might accidentally delete financial information for the entire east cost :). 
If you think this is problematic however, this can always be a configurable value no?

Comment 4 Ayal Baron 2013-10-01 09:47:49 UTC

Warnings are client side anyway, so moving to client.

Comment 5 Dafna Ron 2013-10-02 12:56:18 UTC

here is the upstream bug: 
https://bugs.launchpad.net/swift/+bug/1231495

please look at comment: 

https://bugs.launchpad.net/swift/+bug/1231495/comments/1

Comment 6 Jakub Ruzicka 2013-10-31 10:42:57 UTC

This is an upstream RFE, not a RHOS bug.

It's properly filed upstream by the reporter so I see no reason to track this for RHOS.