Bug 1012644

Summary:	error message from rhc app create --from-code with invalid url should match that of Origin/Online
Product:	OpenShift Container Platform	Reporter:	Peter Ruan <pruan>
Component:	oc	Assignee:	Miciah Dashiel Butler Masters <mmasters>
Status:	CLOSED ERRATA	QA Contact:	libra bugs <libra-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	1.2.1	CC:	bleanhar, gpei, libra-onpremise-devel
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1066283 (view as bug list)		Environment:
Last Closed:	2013-12-16 09:11:26 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1066283

Description Peter Ruan 2013-09-26 18:57:35 UTC

Description of problem:
  When running with Enterprise (rch.1.10.1) with rhc app create --from-code with an invalid URL, the error message should match that given by Origin/Online to be consistent

Online/Origin
=============
Creating application 'wontwork' ... Source code repository could not be cloned: 

Enterprise
=============
Creating application 'wontwork' ... Source Code repository could not be cloned: 

Note the word 'Code' is lower case in Online/Origin.  Please change it so we have a consistent error message across the product lines.

Also,
  URL like 'git:openshift/test-example.git' is considered valid in Origin/Online, but is treated as 'Invalid initial git URL'

Online/Origin
=============
Source code repository could not be cloned: 'git:openshift/test-example.git'.

Enterprise
==========
Creating application 'wontwork' ... Invalid initial git URL



Version-Release number of selected component (if applicable):
rhc version 1.10.1

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 3 Gaoyun Pei 2013-11-18 07:13:15 UTC

Test this on 2.0/2013-11-15.1.

[root@dhcp-8-133 workspace]# rhc app create app1 php --from-code git:openshift/test-example.git
Using php-5.3 (PHP 5.3) for 'php'

Application Options
-------------------
  Domain:      www
  Cartridges:  php-5.3
  Source Code: git:openshift/test-example.git
  Gear Size:   default
  Scaling:     no

Creating application 'app1' ... 
Source code repository could not be cloned:
'git:openshift/test-example.git'. Please verify the repository is
correct and try a non-SSH URL such as HTTP.

The word "code" in "Source code repository could not be cloned:" has been changed to lower-case. And the response of git url is correct.