Bug 1012681

First question before review, will you have intention to support EL5?

Not my area of interest, but I don't see why not.

Hmmm...

You can drop support for EL5 as if it doesn't work well with 1.25 version.

So if you don't need to support EL5(I didn't mean EL6), remove:

BuildRoot tag;
rm -rf %{buildroot} in %install section;
Whole %clean section;
%defattr(-,root,root,-) in %files section.

----------

Source:         %{name}-%{version}.tar.gz

Well, I think you should know pypi, if you think handling this is not perfect, release it to pypi.

----------

BuildRequires:  python-devel

is deprecated and should use BuildRequires:  python2-devel now.

----------

If you ONLY want to support Fedora ;) , please note that you should also(include above python-devel change):

%{__python} --> %{__python2}
%{python_sitearch} --> %{python2_sitearch}

Revised to 0.2.1-2:

Spec URL: http://fedorapeople.org/~grover/new/python-sgutils.spec
SRPM URL: http://fedorapeople.org/~grover/new/python-sgutils-0.2.1-2.el6.src.rpm

Going to play it safe and keep EL6 compatibility for now.

w.r.t. Source, I decided to just host tarballs on fedorahosted.org, so that makes everything easy. May also post to pypi in the future, yes.

Rpmlint (installed packages)
----------------------------
# rpmlint python-sgutils
python-sgutils.i686: E: explicit-lib-dependency sg3_utils-libs
python-sgutils.i686: E: non-standard-executable-perm /usr/lib/python2.7/site-packages/sgutils.so 0775L
1 packages and 0 specfiles checked; 2 errors, 2 warnings.

Let's see:


Requires
--------
python-sgutils (rpmlib, GLIBC filtered):
    libc.so.6
    libpthread.so.0
    libpython2.7.so.1.0
    libsgutils2.so.2
    python(abi)
    rtld(GNU_HASH)
    sg3_utils-libs

So libsgutils2.so.2 is already included, please remove that dep in SPEC.

775 is weird, please contact with upstream and use chmod to fix it in SPEC.

Revised to 0.2.1-3:

Spec URL: http://fedorapeople.org/~grover/new/python-sgutils.spec
SRPM URL: http://fedorapeople.org/~grover/new/python-sgutils-0.2.1-3.el6.src.rpm

* Removed explicit lib dependency
* chmod sgutils.so to 644

PACKAGE APPROVED.

New Package SCM Request
=======================
Package Name: python-sgutils
Short Description: Python support for sg3_utils
Owners: grover
Branches: f18 f19 f20 el6
InitialCC:

Git done (by process-git-requests).

Please use rpmlint when packaging and reviewing.

python-sgutils.x86_64: W: unstripped-binary-or-object /usr/lib64/python2.7/site-packages/sgutils.so
python-sgutils-debuginfo.x86_64: E: empty-debuginfo-package

One way to fix it: just remove the "chmod a-x" line from %install.

(In reply to Christopher Meng from comment #5)
> 775 is weird, please contact with upstream and use chmod to fix it in SPEC.

I suppose something in Rawhide makes *.so 775, in F-19 they end up as 755 as they should. Anyway the fix is not to remove executable bits.

Hi, have you fixed the problem raised by Ville?

building updates now, 0.2.1-4.