Bug 1012944

Summary: Device identifier mismatch when extending iscsi domain
Product: Red Hat Enterprise Virtualization Manager Reporter: David Caro <dcaroest>
Component: vdsmAssignee: Eduardo Warszawski <ewarszaw>
Status: CLOSED ERRATA QA Contact: Aharon Canan <acanan>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 3.3.0CC: abaron, bazulay, danken, dcaroest, eedri, ewarszaw, iheim, lpeer, scohen, yeylon
Target Milestone: ---Keywords: AutomationBlocker, Regression
Target Release: 3.3.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: storage
Fixed In Version: is17 Doc Type: Bug Fix
Doc Text:
A previous commit changed multipath names to be returned as full paths. Consequently, expanding an iSCSI storage domain produced a device identifier mismatch error. Now, device GUIDs are converted into /dev/mapper paths, so extending block storage domains succeeds.
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-01-21 16:16:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description David Caro 2013-09-27 12:28:31 UTC
Description of problem:
When expanding a iscsi storage domain it the following error happens:

2013-09-27 14:30:52,362 ERROR [org.ovirt.engine.core.vdsbroker.irsbroker.ExtendStorageDomainVDSCommand] (ajp-/127.0.0.1:8702-4) Error code InvalidPhysDev and error message IRSGenericException: IRSErrorException: Failed to ExtendStorageDomainVDS, error = Invalid physical device: ('360a9800064775066476f7470697a3959',)

Version-Release number of selected component (if applicable):
4.12.0

How reproducible:
Try to expand an iscsi storage domain

Steps to Reproduce:
1.Setup a cluset with iscsi domain and 1 host
2.Expand the domain with a new device
3.

Actual results:
Expansion failed and error is shown

Expected results:
Expansion happend 

Additional info:

Putting some debug prints on vdsm/storage/blockSD.py near the line 706 shows that the device name and the expected name do not match properly (full path vs just device name):

Code snippet:
           for dev in devlist:
                if dev in knowndevs:
                    devices.append(dev)
                else:
                    raise se.InvalidPhysDev(dev)

Log message:
Thread-67::ERROR::2013-09-27 14:18:04,636::blockSD::706::Storage.StorageDomain::(extend)known: ['/dev/mapper/1kjachim02', '/dev/mapper/1kjachim01', '/dev/mapper/1kjachim03'], dev: 1kjachim03

Comment 3 Sean Cohen 2013-09-29 10:37:06 UTC
David, is it a regression?  is it reproducible?

Comment 5 Ayal Baron 2013-09-29 12:52:40 UTC
looks like a regression introduced by: http://gerrit.ovirt.org/#/c/17967/1

Comment 6 Aharon Canan 2013-10-02 14:39:22 UTC
verified using is17

passed manually and automation as well

Comment 7 Charlie 2013-11-28 00:30:44 UTC
This bug is currently attached to errata RHBA-2013:15291. If this change is not to be documented in the text for this errata please either remove it from the errata, set the requires_doc_text flag to 
minus (-), or leave a "Doc Text" value of "--no tech note required" if you do not have permission to alter the flag.

Otherwise to aid in the development of relevant and accurate release documentation, please fill out the "Doc Text" field above with these four (4) pieces of information:

* Cause: What actions or circumstances cause this bug to present.
* Consequence: What happens when the bug presents.
* Fix: What was done to fix the bug.
* Result: What now happens when the actions or circumstances above occur. (NB: this is not the same as 'the bug doesn't present anymore')

Once filled out, please set the "Doc Type" field to the appropriate value for the type of change made and submit your edits to the bug.

For further details on the Cause, Consequence, Fix, Result format please refer to:

https://bugzilla.redhat.com/page.cgi?id=fields.html#cf_release_notes 

Thanks in advance.

Comment 8 errata-xmlrpc 2014-01-21 16:16:36 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-0040.html