Bug 1013031

Summary: Vault fields are not validated before post installation
Product: [JBoss] JBoss Fuse Service Works 6 Reporter: Pavol Srna <psrna>
Component: InstallerAssignee: Thomas Hauser <thauser>
Status: CLOSED CURRENTRELEASE QA Contact: Pavol Srna <psrna>
Severity: high Docs Contact:
Priority: high    
Version: 6.0.0 GACC: atangrin, fcanas, jsedlace, ncross, psrna, soa-p-jira
Target Milestone: ER4   
Target Release: 6.0.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1013805 1013806 (view as bug list) Environment:
Last Closed: 2014-02-06 15:25:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1013805, 1013806    

Description Pavol Srna 2013-09-27 16:16:53 UTC
Description of problem:

All vault input fields should have some kind of validation before proceeding with post installation.

For example you can enter text in 'iteration count' field where only number is allowed. Or you are not warned when incorrect password for keystore was entered and the installation will fail without consistent error message.

Comment 2 Francisco Canas 2013-09-27 19:52:32 UTC
I have added a numeric validator to the iteration count input field in the vault panel. 

http://git.app.eng.bos.redhat.com/?p=jbossas-installer.git;a=commit;h=43bb2ad8c2134686540f54b7b8382acc54556cb4

Comment 3 Pavol Srna 2013-09-30 09:21:55 UTC
What about to do further validation? For example check if the password entered is correct and can unlock the keystore file. Or if the keystore is a *valid* keystore file. 

Such a validation would improve user experience a lot. Otherwise if something goes wrong then the user gets only a very less saying exception during the installation process.

Comment 4 Thomas Hauser 2013-09-30 19:59:10 UTC
I agree with Pavol here, will create a new BZ for these more advanced validation. This BZ will remain closed to verify the changes made by fcanas above.

Comment 5 Thomas Hauser 2013-09-30 19:59:59 UTC
I agree with Pavol here, will create a new BZ for these more advanced validation. This BZ will remain closed to verify the changes made by fcanas above.

Comment 9 Pavol Srna 2013-10-23 09:47:28 UTC
New bug for more advance validation was opened here: https://bugzilla.redhat.com/show_bug.cgi?id=1013806

Verified that numeric validator to the iteration count input field in the vault panel was added.