Bug 1013097

Summary:	Inconsistency between --consumer-id and --node-id valid characters
Product:	[Retired] Pulp	Reporter:	npallanez
Component:	nodes	Assignee:	Jeff Ortel <jortel>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Preethi Thomas <pthomas>
Severity:	low	Docs Contact:
Priority:	medium
Version:	2.2	CC:	jortel, pthomas
Target Milestone:	---	Keywords:	Triaged
Target Release:	2.3.0
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-12-09 14:29:52 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description npallanez 2013-09-27 20:27:44 UTC

Description of problem:

plup-admin node bind 
--consumer-id accepts "."'s
--node-id does not accept "."'s  

Version-Release number of selected component (if applicable):

2.2

How reproducible:

Steps to Reproduce:
1. pulp-consumer register -u admin --consumer-id foo.goo.com
2. pulp-consumer node activate
3. pulp-admin node bind --repo-id tmprepo --node-id foo.goo.com

Actual results:

Validation failed for argument [--node-id]: value must contain only letters,
numbers, underscores, and hyphens

Expected results:

Valid characters for --consumer-id should be valid for --node-id

Additional info:

Comment 1 Jeff Ortel 2013-09-30 19:14:32 UTC

https://github.com/pulp/pulp/pull/644

Comment 2 Jeff Ortel 2013-10-02 13:30:46 UTC

build: 2.3.0-0.17.beta

Comment 3 Preethi Thomas 2013-10-03 15:10:02 UTC

[root@pulp-v2-server ~]# rpm -qa pulp-server
pulp-server-2.3.0-0.17.beta.el6.noarch
[root@pulp-v2-server ~]# 

[root@pulp-v2-server ~]# pulp-admin node list
+----------------------------------------------------------------------+
                              Child Nodes
+----------------------------------------------------------------------+

Id:               pulp.node1.com
Display Name:     pulp.node1.com
Description:      None
Bindings:         
  Additive: zoo
Update Strategy:  additive
Notes:            


[root@pulp-v2-server ~]# pulp-admin node sync run --node-id pulp.node1.com
This command may be exited via ctrl+c without affecting the request.

[-]
Waiting to begin...



(1/1) Repository: zoo
[==================================================] 100%




Synchronization succeeded

+----------------------------------------------------------------------+
                       Child Node Synchronization
+----------------------------------------------------------------------+

Repository: 
  Action: Added
  Id:     zoo
  Units:  
    Added:   0
    Removed: 0
    Updated: 39



[root@pulp-v2-server ~]#

Comment 4 Preethi Thomas 2013-12-09 14:29:52 UTC

Pulp 2.3 released.