Bug 1013601

Summary: modifyrepo missing <open-size> element and redundant <open-checksum>
Product: [Fedora] Fedora Reporter: Tomas Mlcoch <tmlcoch>
Component: createrepoAssignee: Packaging Maintenance Team <packaging-team-maint>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 19CC: lmacken, packaging-team-maint, zpavlas
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: createrepo-0.10-1.fc19 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-10-30 01:54:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch to fix this bug zpavlas: review+

Description Tomas Mlcoch 2013-09-30 12:33:33 UTC
Created attachment 805174 [details]
Patch to fix this bug

Description of problem:
First issue: When a new compressed metadata file is added, <open-size> element is missing.

Second issue: When a non-compressed metadata file is added, then the <open-checksum> is present (but it shouldn't be).

Steps to Reproduce:
1. modifyrepo foo.xml rpms_sss/repodata

Actual results:
repomd.xml newly contains:
<data type="foo">
  <checksum type="sha256">34dd8ed81e76034e1f8f10f571f7fca142dd516147fe1da043b0c995f6da9ad4</checksum>
  <open-checksum type="sha256">dd767db39e8408b2209a0f8687c31784905a45a36dda81e690230ee8fe39e36f</open-checksum>
  <location href="repodata/34dd8ed81e76034e1f8f10f571f7fca142dd516147fe1da043b0c995f6da9ad4-foo.xml.gz"/>
  <timestamp>1380543226</timestamp>
  <size>246</size>
</data>

Expected results:
repomd.xml newly contains:
<data type="foo">
  <checksum type="sha256">34dd8ed81e76034e1f8f10f571f7fca142dd516147fe1da043b0c995f6da9ad4</checksum>
  <open-checksum type="sha256">dd767db39e8408b2209a0f8687c31784905a45a36dda81e690230ee8fe39e36f</open-checksum>
  <location href="repodata/34dd8ed81e76034e1f8f10f571f7fca142dd516147fe1da043b0c995f6da9ad4-foo.xml.gz"/>
  <timestamp>1380543226</timestamp>
  <size>246</size>
  <open-size>357</open-size>
</data>

Additional info:
Patch attached

Comment 1 Zdeněk Pavlas 2013-09-30 14:25:36 UTC
Comment on attachment 805174 [details]
Patch to fix this bug

ACK

Comment 2 Fedora Update System 2013-10-01 11:54:37 UTC
createrepo-0.9.9-23.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/createrepo-0.9.9-23.fc19

Comment 3 Fedora Update System 2013-10-02 06:50:31 UTC
Package createrepo-0.9.9-23.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing createrepo-0.9.9-23.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-18128/createrepo-0.9.9-23.fc19
then log in and leave karma (feedback).

Comment 4 Fedora Update System 2013-10-18 13:09:27 UTC
createrepo-0.10-0.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/createrepo-0.10-0.fc19

Comment 5 Fedora Update System 2013-10-22 07:32:57 UTC
createrepo-0.10-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/createrepo-0.10-1.fc19

Comment 6 Fedora Update System 2013-10-30 01:54:13 UTC
createrepo-0.10-1.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.