Bug 1014308

Summary: [xfs/xfstests 298] Inline symlink is not removed from inode
Product: Red Hat Enterprise Linux 7 Reporter: Boris Ranto <branto>
Component: kernelAssignee: Dave Chinner <dchinner>
Status: CLOSED CURRENTRELEASE QA Contact: Filesystem QE <fs-qe>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 7.0CC: dchinner, eguan, esandeen, rwheeler
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1014312 (view as bug list) Environment:
Last Closed: 2014-02-23 10:35:44 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 1001861    
Bug Blocks: 1014312    

Description Boris Ranto 2013-10-01 17:16:11 UTC 
Description of problem:
Copied from the description of the test case:
inline symlinks are removed from the inode when an extended attributes forces it into being remote symlink. Warning: this test will ASSERT on unpatched DEBUG XFS.

Version-Release number of selected component (if applicable):
kernel-3.10.0-23.el7.x86_64

How reproducible:
Always

Steps to Reproduce:
1. Run the xfstests test case xfs/298 for xfs fs
2. Check the output

Actual results:
For symlink size 128, the core.nextents is reported to be 1.

Expected results:
The core.nextents is 0.

Additional info:
This seems to have been fixed upstream by [v4] xfs: fix the symbolic link assert in xfs_ifree:
http://patchwork.xfs.org/patch/5614/
Comment 1 Eric Sandeen 2013-10-04 18:55:15 UTC 
Ok, this should be fixed in:

commit 725eb1eb2ae88c200466fec34bcf1fbce4b8eca3
Author: Mark Tinguely <tinguely>
Date:   Mon Jun 17 15:35:57 2013 -0500

    xfs: fix the symbolic link assert in xfs_ifree
    
    Adding an extended attribute to a symbolic link can force that
    link to an remote extent. xfs_inactive() incorrectly assumes
    that any symbolic link small enough to be in the inode core
    is incore, resulting in the remote extent to not be removed.
    xfs_ifree() will assert on presence of this leaked remote extent.
    
    Signed-off-by: Mark Tinguely <tinguely>
    Reviewed-by: Ben Myers <bpm>
    Signed-off-by: Ben Myers <bpm>

which hit:

v3.11-rc1

and should eventually be in RHEL7... when bug #1001861 is done, please retest, and dup this one I guess, if it passes?

Assigning to Dave, but this will probably end up just being a dup.

Thanks,
-Eric
Comment 2 Eryu Guan 2014-02-23 10:35:44 UTC 
kernel-3.10.0-89.el7 passed xfs/298, closed as CURRENTRELEASE.