Bug 1014655

Summary:	JavaDoc should clearly indicated public API/SPI
Product:	[JBoss] JBoss Data Grid 6	Reporter:	Tristan Tarrant <ttarrant>
Component:	Documentation, Build	Assignee:	Misha H. Ali <mhusnain>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Martin Gencur <mgencur>
Severity:	high	Docs Contact:
Priority:	high
Version:	6.2.0	CC:	jdg-bugs, mgencur, mhusnain, ttarrant
Target Milestone:	CR2
Target Release:	6.2.1
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1067724 (view as bug list)		Environment:
Last Closed:	2014-04-04 03:56:34 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	951339, 1067724, 1074359

Description Tristan Tarrant 2013-10-02 13:39:53 UTC

Currently the Javadocs include all classes/interfaces without distinction. We should clearly mark those that are part of the public API/SPI.

Comment 2 Misha H. Ali 2013-10-03 00:00:02 UTC

Blocks Docs API Documentation update bug.

Added myself as docs contact for this bug.

Comment 3 Misha H. Ali 2014-01-13 00:13:12 UTC

Tracking this issue in this bug.

Tristan, according to Martin, the non-public stuff is still in the API docs payload. Adding Martin and Tristan to this bug to track this issue.

Comment 4 Misha H. Ali 2014-01-14 01:41:45 UTC

As part of the API Docs review, Martin please confirm the non-public APIs are not in the docs anymore.

Comment 5 Martin Gencur 2014-01-14 09:42:03 UTC

Misha, this will not be fixed for JDG 6.2 Beta. It needs more effort on productization side.

Comment 8 Adrian Nistor 2014-03-06 16:46:47 UTC

I've integrated the PR https://github.com/infinispan/jdg/pull/31 but I realise now this fixes the issues only partially. Let's not close this yet.

Comment 9 Misha H. Ali 2014-03-07 03:17:15 UTC

This bug includes the docs part of this requirement so please don't close it off till we can get the javadocs in the docs wrapper and staged on the docs server.

Comment 10 Misha H. Ali 2014-03-12 04:05:04 UTC

Hi Martin,

When your team is done testing CR1, would you mind posting here about whether this requirement was met in the included javadocs? If do, we can just close off this bug.

Comment 11 Martin Gencur 2014-03-20 08:37:53 UTC

I've checked the docs included in the library distribution. The docs are mostly correct but I have a few comments:

The following classes/interfaces are IMO redundant and should not be public:
ClearOperation
ClearOperation.Externalizer
GroupManager
GroupManagerImpl
MarshallUtil
Operation
PutOperation
PutOperation.Externalizer
RemoveOperation
RemoveOperation.Externalizer

I'm missing in the docs interfaces from package org.infinispan.persistence.spi,  such as:
CacheLoader, CacheWriter, ExternalStore, AdvancedCacheLoader, etc.

Comment 12 Misha H. Ali 2014-03-23 23:43:35 UTC

Based on Martin's comments, this should probably be back on ASSIGNED.

Updated this and docs API Documentation bug to ASSIGNED to indicate further action required.