Bug 1014789

Summary: eclipse-m2e-core fails to properly execute maven-resources-plugin
Product: [Fedora] Fedora Reporter: Roland Grunberg <rgrunber>
Component: eclipse-m2e-coreAssignee: Gerard Ryan <gerard>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: high    
Version: 19CC: gerard, jon.vanalten, mizdebsk, omajid
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: eclipse-m2e-core-1.4.0-3.fc19 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-10-14 07:06:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Patch none

Description Roland Grunberg 2013-10-02 19:34:49 UTC
Steps to reproduce :

(Ensuring eclipse-m2e-core is installed)

1) hg clone http://icedtea.classpath.org/hg/thermostat
2) Start Eclipse on a separate workspace (thermostat is a fairly large project)
3) File -> Import -> Existing Maven Projects and point to the location of the thermostat project (top-level)
4) You may need to update all the maven projects, but once this is done, the following errors should be in the Problems View :

Execution default-resources of goal org.apache.maven.plugins:maven-resources-plugin:2.6:resources failed. (org.apache.maven.plugins:maven-resources-plugin:2.6:resources:default-resources:process-resources)   pom.xml /thermostat-vm-heap-analysis-client-core        line 47 Maven Build Problem

or

Execution default-resources of goal org.apache.maven.plugins:maven-resources-plugin:2.5:resources failed. (org.apache.maven.plugins:maven-resources-plugin:2.5:resources:default-resources:process-resources)   pom.xml /thermostat-assembly    line 39 Maven Build Problem

There's about 62 of these errors for me but they're pretty much identical.

I believe I've identified the cause as being an NPE in org.codehaus.plexus.util.AbstractScanner#isIncluded called from org.eclipse.m2e.core.internal.builder.ResourceScanner @ line 67 :   if(isIncluded(relpath) && !isExcluded(relpath)) {

In plexus-utils < 3.0.5 (ie. F18) this would not be an issue, but as of 3.0.5 ( F19 + ) plexus-utils introduced a new API method "setupMatchPatterns()" and changed the implementation of "isIncluded/isExcluded/etc." to require that method to have been executed.

I've attached a patch that seems to fix things for me (scratch build at http://koji.fedoraproject.org/koji/taskinfo?taskID=6016916)

An additional specfile change was needed to get dependencies resolving properly.

Comment 1 Roland Grunberg 2013-10-02 19:35:54 UTC
Created attachment 806695 [details]
Patch

Comment 2 Jon VanAlten 2013-10-02 20:45:09 UTC
Hi, I was seeing this issue (# of errors reported in eclipse varied from time to time but essentially same as described).  After installing scratch build, issue seems to be fixed.  Thanks a lot!!!!

Comment 3 Gerard Ryan 2013-10-02 22:10:09 UTC
Thanks for the bug report and the patch Roland (and thanks for the feedback Jon). I'll check it out tomorrow and push an update.

Comment 4 Mikolaj Izdebski 2013-10-03 08:54:56 UTC
This happens to me too on Fedora 19, but not Fedora 18.

Comment 5 Fedora Update System 2013-10-03 17:02:29 UTC
eclipse-m2e-core-1.4.0-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/eclipse-m2e-core-1.4.0-3.fc19

Comment 6 Roland Grunberg 2013-10-03 19:33:05 UTC
Although this will fix things for f19, I think this will need to be applied in rawhide, and f20 as well (since plexus-utils > 3.0.5 are present in those targets).

Comment 7 Gerard Ryan 2013-10-03 22:23:38 UTC
(In reply to Roland Grunberg from comment #6)
> Although this will fix things for f19, I think this will need to be applied
> in rawhide, and f20 as well (since plexus-utils > 3.0.5 are present in those
> targets).

Good point. I've added the fix to rawhide & f20 branches, and added the f20 build as an update. Thanks again!

Comment 8 Fedora Update System 2013-10-04 02:01:40 UTC
Package eclipse-m2e-core-1.4.0-3.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing eclipse-m2e-core-1.4.0-3.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-18261/eclipse-m2e-core-1.4.0-3.fc19
then log in and leave karma (feedback).

Comment 9 Fedora Update System 2013-10-14 07:06:10 UTC
eclipse-m2e-core-1.4.0-3.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2013-10-14 17:13:03 UTC
eclipse-m2e-core-1.4.0-3.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.