Bug 1014827

Summary:	The path of a puppet module includes the author which makes it unusable by puppetmaster
Product:	Red Hat Satellite	Reporter:	Ivan Necas <inecas>
Component:	Content Management	Assignee:	David Davis <daviddavis>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Katello QA List <katello-qa-list>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	6.0.2	CC:	cwelton, daviddavis, dcleal, ehelms, jmontleo, mhrivnak, omaciel
Target Milestone:	Unspecified	Keywords:	Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-04-24 17:08:03 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ivan Necas 2013-10-02 21:06:06 UTC

Steps to Reproduce:
1. set puppetmaster on the system
2. upload a puppet package to katello (e.g. https://forge.puppetlabs.com/jproyo/git/0.1.0.tar.gz)
3. publish content view with the puppet repo
4. see /etc/puppet/environments/KT_ACME_Corporation_Library_cv_1 (replace with your content view dir) 

Actual results:
there is jporyo-git module

Expected results:
there is git module

Additional info:

The problem is that that metadata.json in the tar.gz have "name": "jproyo-git". From the discussion over IRC with mhrivnak, it seems we need to change the metadata computation in Katello to have {"name":"git", "author":"jproyo"}, although we loose the information about the full author name "Juan Pablo Royo", as this is how puppetforge behaves as well https://forge.puppetlabs.com/jproyo/git.json

Comment 2 David Davis 2013-10-03 17:00:22 UTC

https://github.com/Katello/katello/pull/3084

Comment 3 David Davis 2013-10-07 14:29:05 UTC

I checked the CLI and while it sends extra data with unit_metadata, it should work fine (confirmed with pulp). I did open a Github issue though:

https://github.com/Katello/katello/issues/3083

Comment 4 David Davis 2013-10-07 14:29:38 UTC

katello SHA 3049ce05808bb1c7ae1e47182c7f66002e895ba0

1014827: Fixing unit_key and unit_metadata

Comment 7 Og Maciel 2013-10-21 20:50:49 UTC

There's a discrepancy between importing via the UI x CLI:

Imported http://forge.puppetlabs.com/theforeman/git/1.2.0.tar.gz via cli and the module was saved as /etc/puppet/environments/KT_Katello_Infrastructure_Library_PublishedPuppetForgeCVD_17/modules/theforeman-git

Imported https://forge.puppetlabs.com/jproyo/git/0.1.0.tar.gz via UI and the module was saved as /etc/puppet/environments/KT_Katello_Infrastructure_Library_PublishedPuppetForgeCVD_17/modules/git

I believe the last result is the expected fix.

Comment 8 Og Maciel 2013-10-21 20:57:05 UTC

Verified:

* apr-util-ldap-1.3.9-3.el6_0.1.x86_64
* candlepin-0.8.25-1.el6sam.noarch
* candlepin-scl-1-5.el6_4.noarch
* candlepin-scl-quartz-2.1.5-5.el6_4.noarch
* candlepin-scl-rhino-1.7R3-1.el6_4.noarch
* candlepin-scl-runtime-1-5.el6_4.noarch
* candlepin-selinux-0.8.25-1.el6sam.noarch
* candlepin-tomcat6-0.8.25-1.el6sam.noarch
* elasticsearch-0.19.9-8.el6sat.noarch
* foreman-1.3.0-18.el6sat.noarch
* foreman-compute-1.3.0-18.el6sat.noarch
* foreman-libvirt-1.3.0-18.el6sat.noarch
* foreman-postgresql-1.3.0-18.el6sat.noarch
* foreman-proxy-1.3.0-3.el6sat.noarch
* katello-1.4.6-39.el6sat.noarch
* katello-all-1.4.6-39.el6sat.noarch
* katello-candlepin-cert-key-pair-1.0-1.noarch
* katello-certs-tools-1.4.4-1.el6sat.noarch
* katello-cli-1.4.3-24.el6sat.noarch
* katello-cli-common-1.4.3-24.el6sat.noarch
* katello-common-1.4.6-39.el6sat.noarch
* katello-configure-1.4.7-5.el6sat.noarch
* katello-configure-foreman-1.4.7-5.el6sat.noarch
* katello-configure-foreman-proxy-1.4.7-5.el6sat.noarch
* katello-foreman-all-1.4.6-39.el6sat.noarch
* katello-glue-candlepin-1.4.6-39.el6sat.noarch
* katello-glue-elasticsearch-1.4.6-39.el6sat.noarch
* katello-glue-pulp-1.4.6-39.el6sat.noarch
* katello-qpid-broker-key-pair-1.0-1.noarch
* katello-qpid-client-key-pair-1.0-1.noarch
* katello-selinux-1.4.4-4.el6sat.noarch
* openldap-2.4.23-31.el6.x86_64
* pulp-katello-plugins-0.2-1.el6sat.noarch
* pulp-nodes-common-2.3.0-0.22.beta.el6sat.noarch
* pulp-nodes-parent-2.3.0-0.22.beta.el6sat.noarch
* pulp-puppet-plugins-2.3.0-0.22.beta.el6sat.noarch
* pulp-rpm-plugins-2.3.0-0.22.beta.el6sat.noarch
* pulp-selinux-2.3.0-0.22.beta.el6sat.noarch
* pulp-server-2.3.0-0.22.beta.el6sat.noarch
* python-ldap-2.3.10-1.el6.x86_64
* ruby193-rubygem-ldap_fluff-0.2.2-2.el6sat.noarch
* ruby193-rubygem-net-ldap-0.3.1-3.el6sat.noarch
* ruby193-rubygem-runcible-1.0.7-1.el6sat.noarch
* signo-0.0.22-2.el6sat.noarch
* signo-katello-0.0.22-2.el6sat.noarch

Comment 11 Bryan Kearney 2014-04-24 17:08:03 UTC

This was verified and delivered with MDP2. Closing it out.